Skip to content

Commit d419f43

Browse files
committed
[BE] MissingMagicSerializationMethodsRule
1 parent 879590d commit d419f43

File tree

5 files changed

+2
-9
lines changed

5 files changed

+2
-9
lines changed

changelog-2.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Major new features 🚀
2020
* Check that each trait is used and analysed at least once (level 4) (https://github.com/phpstan/phpstan-src/commit/c4d05276fb8605d6ac20acbe1cc5df31cd6c10b0)
2121
* Check preg_quote delimiter sanity (level 0) ([#3252](https://github.com/phpstan/phpstan-src/pull/3252)), #11338, thanks @staabm!
2222
* MagicConstantContextRule (level 0) ([#2741](https://github.com/phpstan/phpstan-src/pull/2741)), #10099, thanks @staabm!
23+
* MissingMagicSerializationMethodsRule (level 0) ([#1711](https://github.com/phpstan/phpstan-src/pull/1711)), #7482, thanks @staabm!
2324
* Rule for `call_user_func()` (level 5) ([#2479](https://github.com/phpstan/phpstan-src/pull/2479)), thanks @staabm!
2425
* Check array functions which require stringish values (level 5) ([#3132](https://github.com/phpstan/phpstan-src/pull/3132)), #11141, #5848, #3694, #11111, thanks @schlndh!
2526
* Check variance of template types in properties (level 2) ([#2314](https://github.com/phpstan/phpstan-src/pull/2314)), thanks @jiripudil!
@@ -63,7 +64,6 @@ Bleeding edge (TODO move to other sections)
6364
* Support `@readonly` property and `@immutable` class PHPDoc ([#1295](https://github.com/phpstan/phpstan-src/pull/1295), [#1335](https://github.com/phpstan/phpstan-src/pull/1335)), #4082, thanks @herndlm!
6465
* Move IllegalConstructorMethodCallRule and IllegalConstructorStaticCallRule to phpstan-strict-rules (https://github.com/phpstan/phpstan-src/commit/124b30f98c182193187be0b9c2e151e477429b7a, https://github.com/phpstan/phpstan-strict-rules/commit/0c82c96f2a55d8b91bbc7ee6512c94f68a206b43)
6566
* Add `@readonly` rule that disallows default values ([#1391](https://github.com/phpstan/phpstan-src/pull/1391)), thanks @herndlm!
66-
* MissingMagicSerializationMethodsRule ([#1711](https://github.com/phpstan/phpstan-src/pull/1711)), #7482, thanks @staabm!
6767
* Always report always true conditions, except for last elseif and match arm ([#2105](https://github.com/phpstan/phpstan-src/pull/2105)), thanks @staabm!
6868
* Disable "unreachable branches" rules: UnreachableIfBranchesRule, UnreachableTernaryElseBranchRule, unreachable arm error in MatchExpressionRule
6969
* Because "always true" is always reported, these are no longer needed

conf/bleedingEdge.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ parameters:
99
arrayValues: true
1010
looseComparison: true
1111
readOnlyByPhpDoc: true
12-
missingMagicSerializationRule: true
1312
alwaysCheckTooWideReturnTypeFinalMethods: true
1413
alwaysTrueAlwaysReported: true
1514
disableUnreachableBranchesRules: true

conf/config.level0.neon

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ conditionalTags:
88
phpstan.rules.rule: %featureToggles.readOnlyByPhpDoc%
99
PHPStan\Rules\Properties\UninitializedPropertyRule:
1010
phpstan.rules.rule: %checkUninitializedProperties%
11-
PHPStan\Rules\Methods\MissingMagicSerializationMethodsRule:
12-
phpstan.rules.rule: %featureToggles.missingMagicSerializationRule%
1311
PHPStan\Rules\Functions\UselessFunctionReturnValueRule:
1412
phpstan.rules.rule: %featureToggles.uselessReturnValue%
1513
PHPStan\Rules\Functions\PrintfArrayParametersRule:
@@ -93,6 +91,7 @@ rules:
9391
- PHPStan\Rules\Methods\FinalPrivateMethodRule
9492
- PHPStan\Rules\Methods\MethodCallableRule
9593
- PHPStan\Rules\Methods\MethodVisibilityInInterfaceRule
94+
- PHPStan\Rules\Methods\MissingMagicSerializationMethodsRule
9695
- PHPStan\Rules\Methods\MissingMethodImplementationRule
9796
- PHPStan\Rules\Methods\MethodAttributesRule
9897
- PHPStan\Rules\Methods\StaticMethodCallableRule
@@ -259,9 +258,6 @@ services:
259258
arguments:
260259
additionalConstructors: %additionalConstructors%
261260

262-
-
263-
class: PHPStan\Rules\Methods\MissingMagicSerializationMethodsRule
264-
265261
-
266262
class: PHPStan\Rules\Functions\UselessFunctionReturnValueRule
267263

conf/config.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ parameters:
3030
illegalConstructorMethodCall: false
3131
looseComparison: false
3232
readOnlyByPhpDoc: false
33-
missingMagicSerializationRule: false
3433
alwaysCheckTooWideReturnTypeFinalMethods: false
3534
alwaysTrueAlwaysReported: false
3635
disableUnreachableBranchesRules: false

conf/parametersSchema.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ parametersSchema:
3636
illegalConstructorMethodCall: bool(),
3737
looseComparison: bool(),
3838
readOnlyByPhpDoc: bool()
39-
missingMagicSerializationRule: bool()
4039
alwaysCheckTooWideReturnTypeFinalMethods: bool()
4140
alwaysTrueAlwaysReported: bool()
4241
disableUnreachableBranchesRules: bool()

0 commit comments

Comments
 (0)