fix array_push()/array_pop()

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -2684,6 +2684,10 @@ static function (): void {
 
 				$arrayArg = $expr->getArgs()[0]->value;
 				$scope = $scope->invalidateExpression($arrayArg)->assignExpression($arrayArg, $arrayType, $arrayNativeType);
+
+				if ($arrayArg instanceof PropertyFetch || $arrayArg instanceof StaticPropertyFetch) {
+					$nodeCallback(new PropertyAssignNode($arrayArg, new TypeExpr($scope->getType($arrayArg)), false), $scope);
+				}
 			}
 
 			if (

tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php

@@ -860,4 +860,26 @@ public function testBug13438c(): void
 		$this->analyse([__DIR__ . '/data/bug-13438c.php'], []);
 	}
 
+	public function testBug13438d(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-13438d.php'], [
+			[
+				'Property Bug13438d\Test::$queue (array{}) does not accept array{1}.',
+				18,
+			],
+		]);
+	}
+
+	public function testBug13438e(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-13438e.php'], [
+			[
+				'Property Bug13438e\Test::$queue (array{}) does not accept array{1}.',
+				18,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-13438d.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Bug13438d;
+
+class Test
+{
+	/**
+	 * @param array{} $queue
+	 */
+	public function __construct(
+		private array $queue,
+	)
+	{
+	}
+
+	public function test1(): int
+	{
+		return array_push($this->queue, 1);
+	}
+}

tests/PHPStan/Rules/Properties/data/bug-13438e.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Bug13438e;
+
+class Test
+{
+	/**
+	 * @param array{} $queue
+	 */
+	public function __construct(
+		private array $queue,
+	)
+	{
+	}
+
+	public function test1(): int
+	{
+		return array_unshift($this->queue, 1);
+	}
+}