Skip to content

Commit d9cc0de

Browse files
committed
fixup! Add stringable access check to ClassConstantRule
1 parent 808ed2e commit d9cc0de

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

conf/config.level0.neon

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ conditionalTags:
1616
phpstan.rules.rule: %featureToggles.newStaticInAbstractClassStaticMethod%
1717

1818
services:
19-
-
20-
class: PHPStan\Rules\Classes\ClassConstantRule
2119

2220
-
2321
class: PHPStan\Rules\Classes\NewStaticInAbstractClassStaticMethodRule

src/Rules/Classes/ClassConstantRule.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
use PhpParser\Node\Scalar\String_;
1010
use PHPStan\Analyser\NullsafeOperatorHelper;
1111
use PHPStan\Analyser\Scope;
12+
use PHPStan\DependencyInjection\AutowiredParameter;
13+
use PHPStan\DependencyInjection\AutowiredService;
1214
use PHPStan\DependencyInjection\RegisteredRule;
1315
use PHPStan\Internal\SprintfHelper;
1416
use PHPStan\Php\PhpVersion;
@@ -34,6 +36,7 @@
3436
/**
3537
* @implements Rule<Node\Expr\ClassConstFetch>
3638
*/
39+
#[AutowiredService]
3740
#[RegisteredRule(level: 0)]
3841
final class ClassConstantRule implements Rule
3942
{
@@ -43,7 +46,8 @@ public function __construct(
4346
private RuleLevelHelper $ruleLevelHelper,
4447
private ClassNameCheck $classCheck,
4548
private PhpVersion $phpVersion,
46-
private bool $checkNonStringableDynamicAccess = true,
49+
#[AutowiredParameter(ref: '%featureToggles.checkNonStringableDynamicAccess%')]
50+
private bool $checkNonStringableDynamicAccess,
4751
)
4852
{
4953
}

0 commit comments

Comments
 (0)