[BE] ConstantLooseComparisonRule

Author: ondrejmirtes

changelog-2.0.md

@@ -27,6 +27,7 @@ Major new features 🚀
 * Check vprintf/vsprintf arguments against placeholder count (level 0) ([#3126](https://github.com/phpstan/phpstan-src/pull/3126)), thanks @staabm!
 * Report useless return values of function calls like `var_export` without `$return=true` (level 0) ([#3225](https://github.com/phpstan/phpstan-src/pull/3225)), #11320, thanks @staabm!
 * Rule for `call_user_func()` (level 5) ([#2479](https://github.com/phpstan/phpstan-src/pull/2479)), thanks @staabm!
+* ConstantLooseComparisonRule - level 4 (https://github.com/phpstan/phpstan-src/commit/6ebf2361a3c831dd105a815521889428c295dc9f)
 * Check array functions which require stringish values (level 5) ([#3132](https://github.com/phpstan/phpstan-src/pull/3132)), #11141, #5848, #3694, #11111, thanks @schlndh!
 * Check variance of template types in properties (level 2) ([#2314](https://github.com/phpstan/phpstan-src/pull/2314)), thanks @jiripudil!
 * ArrayUnpackingRule (level 3) ([#856](https://github.com/phpstan/phpstan-src/pull/856)), thanks @canvural!
@@ -64,7 +65,6 @@ Bleeding edge (TODO move to other sections)
 
 * Report useless `array_filter()` calls ([#1077](https://github.com/phpstan/phpstan-src/pull/1077)), #6840, thanks @leongersen!
 * Rules for checking direct calls to `__construct()` (level 2) ([#1208](https://github.com/phpstan/phpstan-src/pull/1208)), #7022, thanks @muno92!
-* ConstantLooseComparisonRule - level 4 (https://github.com/phpstan/phpstan-src/commit/6ebf2361a3c831dd105a815521889428c295dc9f)
 * Support `@readonly` property and `@immutable` class PHPDoc ([#1295](https://github.com/phpstan/phpstan-src/pull/1295), [#1335](https://github.com/phpstan/phpstan-src/pull/1335)), #4082, thanks @herndlm!
 * Move IllegalConstructorMethodCallRule and IllegalConstructorStaticCallRule to phpstan-strict-rules (https://github.com/phpstan/phpstan-src/commit/124b30f98c182193187be0b9c2e151e477429b7a, https://github.com/phpstan/phpstan-strict-rules/commit/0c82c96f2a55d8b91bbc7ee6512c94f68a206b43)
 * Add `@readonly` rule that disallows default values ([#1391](https://github.com/phpstan/phpstan-src/pull/1391)), thanks @herndlm!

conf/bleedingEdge.neon

@@ -6,7 +6,6 @@ parameters:
 
 		arrayFilter: true
 		arrayValues: true
-		looseComparison: true
 		readOnlyByPhpDoc: true
 		pure: true
 		requireFileExists: true

conf/config.level4.neon

@@ -21,8 +21,6 @@ rules:
 	- PHPStan\Rules\Traits\NotAnalysedTraitRule
 
 conditionalTags:
-	PHPStan\Rules\Comparison\ConstantLooseComparisonRule:
-		phpstan.rules.rule: %featureToggles.looseComparison%
 	PHPStan\Rules\DeadCode\CallToConstructorStatementWithoutImpurePointsRule:
 		phpstan.rules.rule: %featureToggles.pure%
 	PHPStan\Rules\DeadCode\PossiblyPureNewCollector:
@@ -220,6 +218,8 @@ services:
 			treatPhpDocTypesAsCertain: %treatPhpDocTypesAsCertain%
 			reportAlwaysTrueInLastCondition: %reportAlwaysTrueInLastCondition%
 			treatPhpDocTypesAsCertainTip: %tips.treatPhpDocTypesAsCertain%
+		tags:
+			- phpstan.rules.rule
 
 	-
 		class: PHPStan\Rules\Comparison\TernaryOperatorConstantConditionRule

conf/config.neon

@@ -27,7 +27,6 @@ parameters:
 		arrayFilter: false
 		arrayValues: false
 		illegalConstructorMethodCall: false
-		looseComparison: false
 		readOnlyByPhpDoc: false
 		stricterFunctionMap: false
 		pure: false
@@ -862,7 +861,6 @@ services:
 		class: PHPStan\Rules\Comparison\ConstantConditionRuleHelper
 		arguments:
 			treatPhpDocTypesAsCertain: %treatPhpDocTypesAsCertain%
-			looseComparisonRuleEnabled: %featureToggles.looseComparison%
 
 	-
 		class: PHPStan\Rules\Comparison\ImpossibleCheckTypeHelper

conf/parametersSchema.neon

@@ -33,7 +33,6 @@ parametersSchema:
 		arrayFilter: bool(),
 		arrayValues: bool(),
 		illegalConstructorMethodCall: bool(),
-		looseComparison: bool(),
 		readOnlyByPhpDoc: bool()
 		stricterFunctionMap: bool()
 		pure: bool()

src/Rules/Comparison/ConstantConditionRuleHelper.php

@@ -14,7 +14,6 @@ final class ConstantConditionRuleHelper
 	public function __construct(
 		private ImpossibleCheckTypeHelper $impossibleCheckTypeHelper,
 		private bool $treatPhpDocTypesAsCertain,
-		private bool $looseComparisonRuleEnabled,
 	)
 	{
 	}
@@ -32,10 +31,8 @@ public function shouldReportAlwaysTrueByDefault(Expr $expr): bool
 	public function shouldSkip(Scope $scope, Expr $expr): bool
 	{
 		if (
-			$this->looseComparisonRuleEnabled
-			&& ($expr instanceof Expr\BinaryOp\Equal
-				|| $expr instanceof Expr\BinaryOp\NotEqual
-			)
+			$expr instanceof Expr\BinaryOp\Equal
+			|| $expr instanceof Expr\BinaryOp\NotEqual
 		) {
 			return true;
 		}