Adjust InvalidThrowsPhpDocValueRule for property hooks

Author: ondrejmirtes

src/Rules/PhpDoc/InvalidThrowsPhpDocValueRule.php

@@ -3,7 +3,9 @@
 namespace PHPStan\Rules\PhpDoc;
 
 use PhpParser\Node;
+use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
+use PHPStan\Node\InPropertyHookNode;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\FileTypeMapper;
@@ -16,7 +18,7 @@
 use function sprintf;
 
 /**
- * @implements Rule<Node\Stmt>
+ * @implements Rule<NodeAbstract>
  */
 final class InvalidThrowsPhpDocValueRule implements Rule
 {
@@ -27,13 +29,17 @@ public function __construct(private FileTypeMapper $fileTypeMapper)
 
 	public function getNodeType(): string
 	{
-		return Node\Stmt::class;
+		return NodeAbstract::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if ($node instanceof Node\Stmt\Function_ || $node instanceof Node\Stmt\ClassMethod) {
-			return []; // is handled by virtual nodes
+		if ($node instanceof Node\Stmt) {
+			if ($node instanceof Node\Stmt\Function_ || $node instanceof Node\Stmt\ClassMethod) {
+				return []; // is handled by virtual nodes
+			}
+		} elseif (!$node instanceof InPropertyHookNode) {
+			return [];
 		}
 
 		$docComment = $node->getDocComment();

tests/PHPStan/Rules/PhpDoc/InvalidThrowsPhpDocValueRuleTest.php

@@ -9,6 +9,7 @@
 use PHPStan\Testing\RuleTestCase;
 use PHPStan\Type\FileTypeMapper;
 use PHPStan\Type\VerbosityLevel;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<InvalidThrowsPhpDocValueRule>
@@ -137,4 +138,18 @@ public function testMergeInheritedPhpDocs(
 		$this->assertSame($expectedType, $throwsType->describe(VerbosityLevel::precise()));
 	}
 
+	public function testPropertyHooks(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->analyse([__DIR__ . '/data/invalid-throws-property-hook.php'], [
+			[
+				'PHPDoc tag @throws with type DateTimeImmutable is not subtype of Throwable',
+				17,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/PhpDoc/data/invalid-throws-property-hook.php

@@ -0,0 +1,22 @@
+<?php // lint >= 8.4
+
+namespace InvalidThrowsPropertyHook;
+
+class Foo
+{
+
+	public int $i {
+		/** @throws \InvalidArgumentException */
+		get {
+			return 1;
+		}
+	}
+
+	public int $j {
+		/** @throws \DateTimeImmutable */
+		get {
+			return 1;
+		}
+	}
+
+}