fix cs

jiripudil · jiripudil · commit dd4df25c0505 · 2024-10-07T14:47:34.000+02:00
diff --git a/src/Rules/Generics/TemplateTypeCheck.php b/src/Rules/Generics/TemplateTypeCheck.php
@@ -185,11 +185,13 @@ public function check(
 				$messages[] = $genericDefaultError;
 			}
 
-			if ($boundType->accepts($defaultType, $scope->isDeclareStrictTypes())->no()) {
-				$messages[] = RuleErrorBuilder::message(sprintf($defaultNotSubtypeOfBoundMessage, $defaultType->describe(VerbosityLevel::typeOnly()), $templateTagName, $boundType->describe(VerbosityLevel::typeOnly())))
-					->identifier('generics.templateDefaultOutOfBounds')
-					->build();
+			if (!$boundType->accepts($defaultType, $scope->isDeclareStrictTypes())->no()) {
+				continue;
 			}
+
+			$messages[] = RuleErrorBuilder::message(sprintf($defaultNotSubtypeOfBoundMessage, $defaultType->describe(VerbosityLevel::typeOnly()), $templateTagName, $boundType->describe(VerbosityLevel::typeOnly())))
+				->identifier('generics.templateDefaultOutOfBounds')
+				->build();
 		}
 
 		return $messages;

Original file line number	Diff line number	Diff line change
`@@ -185,11 +185,13 @@ public function check(`
`185`	`185`	`$messages[] = $genericDefaultError;`
`186`	`186`	`}`
`187`	`187`
`188`		`- if ($boundType->accepts($defaultType, $scope->isDeclareStrictTypes())->no()) {`
`189`		`- $messages[] = RuleErrorBuilder::message(sprintf($defaultNotSubtypeOfBoundMessage, $defaultType->describe(VerbosityLevel::typeOnly()), $templateTagName, $boundType->describe(VerbosityLevel::typeOnly())))`
`190`		`- ->identifier('generics.templateDefaultOutOfBounds')`
`191`		`- ->build();`
	`188`	`+ if (!$boundType->accepts($defaultType, $scope->isDeclareStrictTypes())->no()) {`
	`189`	`+ continue;`
`192`	`190`	`}`
	`191`	`+`
	`192`	`+ $messages[] = RuleErrorBuilder::message(sprintf($defaultNotSubtypeOfBoundMessage, $defaultType->describe(VerbosityLevel::typeOnly()), $templateTagName, $boundType->describe(VerbosityLevel::typeOnly())))`
	`193`	`+ ->identifier('generics.templateDefaultOutOfBounds')`
	`194`	`+ ->build();`
`193`	`195`	`}`
`194`	`196`
`195`	`197`	`return $messages;`