Test MethodCall, StaticMethodCall

Author: staabm

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleTest.php

@@ -275,6 +275,21 @@ public function testBug12473(): void
 		]);
 	}
 
+	#[RequiresPhp('>= 8.1')]
+	public function testBug12087b(): void
+	{
+		$tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.';
+
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-12087b.php'], [
+			[
+				'Call to method Bug12087b\MyAssert::is_null() with null will always evaluate to true.',
+				37,
+				$tipText,
+			],
+		]);
+	}
+
 	public static function getAdditionalConfigFiles(): array
 	{
 		return [

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeStaticMethodCallRuleTest.php

@@ -5,6 +5,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 
 /**
  * @extends RuleTestCase<ImpossibleCheckTypeStaticMethodCallRule>
@@ -145,6 +146,21 @@ public function testReportAlwaysTrueInLastCondition(bool $reportAlwaysTrueInLast
 		$this->analyse([__DIR__ . '/data/impossible-static-method-report-always-true-last-condition.php'], $expectedErrors);
 	}
 
+	#[RequiresPhp('>= 8.1')]
+	public function testBug12087b(): void
+	{
+		$tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.';
+
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-12087b.php'], [
+			[
+				'Call to static method Bug12087b\MyAssert::static_is_null() with null will always evaluate to true.',
+				31,
+				$tipText,
+			],
+		]);
+	}
+
 	public static function getAdditionalConfigFiles(): array
 	{
 		return [

tests/PHPStan/Rules/Comparison/data/bug-12087b.php

@@ -0,0 +1,38 @@
+<?php // lint >= 8.1
+
+namespace Bug12087b;
+
+enum Button: int
+{
+	case On = 1;
+
+	case Off = 0;
+}
+
+class MyAssert {
+	/**
+	 * @return ($value is null ? true : false)
+	 */
+	static public function static_is_null(mixed $value): bool {
+		return $value === null;
+	}
+
+	/**
+	 * @return ($value is null ? true : false)
+	 */
+	public function is_null(mixed $value): bool {
+		return $value === null;
+	}
+}
+
+function doFoo(): void {
+	$value = 10;
+
+	MyAssert::static_is_null($value = Button::tryFrom($value));
+}
+
+function doBar(MyAssert $assert): void {
+	$value = 10;
+
+	$assert->is_null($value = Button::tryFrom($value));
+}