Cover readonly hooked properties in abstract classes

Author: jakubtobiasz

src/Rules/Properties/PropertyInClassRule.php

@@ -72,8 +72,6 @@ public function processNode(Node $node, Scope $scope): array
 						->build(),
 				];
 			}
-
-			return [];
 		}
 
 		if ($node->isReadOnly()) {
@@ -87,13 +85,15 @@ public function processNode(Node $node, Scope $scope): array
 			}
 		}
 
-		if (!$this->doAllHooksHaveBody($node)) {
-			return [
-				RuleErrorBuilder::message('Non-abstract properties cannot include hooks without bodies.')
-					->nonIgnorable()
-					->identifier('property.hookWithoutBody')
-					->build(),
-			];
+		if (!$node->isAbstract() && !$node->isReadOnly()) {
+			if (!$this->doAllHooksHaveBody($node)) {
+				return [
+					RuleErrorBuilder::message('Non-abstract properties cannot include hooks without bodies.')
+						->nonIgnorable()
+						->identifier('property.hookWithoutBody')
+						->build(),
+				];
+			}
 		}
 
 		return [];

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -170,6 +170,10 @@ public function testPhp84AndReadonlyHookedProperties(): void
 				'Hooked properties cannot be readonly.',
 				14,
 			],
+			[
+				'Hooked properties cannot be readonly.',
+				19,
+			]
 		]);
 	}
 

tests/PHPStan/Rules/Properties/data/hooked-properties-without-bodies-in-class.php

@@ -12,7 +12,7 @@ class AbstractPerson
 class PromotedHookedPropertyWithoutVisibility
 {
 
-	public function __construct(mixed $test { get; })
+	public function __construct(public mixed $test { get; })
 	{
 
 	}

tests/PHPStan/Rules/Properties/data/readonly-property-hooks.php

@@ -13,3 +13,8 @@ class HelloWorld
 
 	public readonly string $lastName { set => $this->lastName; }
 }
+
+abstract class HelloWorld
+{
+	public abstract readonly string $firstName { get { return 'jake'; } set; }
+}