Ignore non-explicit NeverType in purity check

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -4330,7 +4330,13 @@ public function createCallableParameters(Scope $scope, Expr $closureExpr, ?array
 	{
 		$callableParameters = null;
 		if ($args !== null) {
-			$acceptors = $scope->getType($closureExpr)->getCallableParametersAcceptors($scope);
+			$closureType = $scope->getType($closureExpr);
+
+			if ($closureType->isCallable()->no()) {
+				return null;
+			}
+
+			$acceptors = $closureType->getCallableParametersAcceptors($scope);
 			if (count($acceptors) === 1) {
 				$callableParameters = $acceptors[0]->getParameters();
 
@@ -4356,6 +4362,10 @@ public function createCallableParameters(Scope $scope, Expr $closureExpr, ?array
 					$passedToType->getTypes(),
 					static fn (Type $type) => $type->isCallable()->yes(),
 				));
+
+				if ($passedToType->isCallable()->no()) {
+					return null;
+				}
 			}
 
 			$acceptors = $passedToType->getCallableParametersAcceptors($scope);

src/Type/NeverType.php

@@ -9,7 +9,6 @@
 use PHPStan\Reflection\ConstantReflection;
 use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Reflection\PropertyReflection;
-use PHPStan\Reflection\TrivialParametersAcceptor;
 use PHPStan\Reflection\Type\UnresolvedMethodPrototypeReflection;
 use PHPStan\Reflection\Type\UnresolvedPropertyPrototypeReflection;
 use PHPStan\ShouldNotHappenException;
@@ -334,12 +333,12 @@ public function shuffleArray(): Type
 
 	public function isCallable(): TrinaryLogic
 	{
-		return TrinaryLogic::createYes();
+		return TrinaryLogic::createNo();
 	}
 
 	public function getCallableParametersAcceptors(ClassMemberAccessAnswerer $scope): array
 	{
-		return [new TrivialParametersAcceptor()];
+		throw new ShouldNotHappenException();
 	}
 
 	public function isCloneable(): TrinaryLogic

tests/PHPStan/Rules/Pure/PureMethodRuleTest.php

@@ -12,13 +12,21 @@
 class PureMethodRuleTest extends RuleTestCase
 {
 
+	private bool $treatPhpDocTypesAsCertain;
+
 	public function getRule(): Rule
 	{
 		return new PureMethodRule(new FunctionPurityCheck());
 	}
 
+	protected function shouldTreatPhpDocTypesAsCertain(): bool
+	{
+		return $this->treatPhpDocTypesAsCertain;
+	}
+
 	public function testRule(): void
 	{
+		$this->treatPhpDocTypesAsCertain = true;
 		$this->analyse([__DIR__ . '/data/pure-method.php'], [
 			[
 				'Method PureMethod\Foo::doFoo() is marked as pure but parameter $p is passed by reference.',
@@ -141,6 +149,7 @@ public function testPureConstructor(): void
 			$this->markTestSkipped('Test requires PHP 8.0.');
 		}
 
+		$this->treatPhpDocTypesAsCertain = true;
 		$this->analyse([__DIR__ . '/data/pure-constructor.php'], [
 			[
 				'Impure property assignment in pure method PureConstructor\Foo::__construct().',
@@ -159,6 +168,7 @@ public function testPureConstructor(): void
 
 	public function testImpureAssignRef(): void
 	{
+		$this->treatPhpDocTypesAsCertain = true;
 		$this->analyse([__DIR__ . '/data/impure-assign-ref.php'], [
 			[
 				'Possibly impure property assignment by reference in pure method ImpureAssignRef\HelloWorld::bar6().',
@@ -167,4 +177,21 @@ public function testImpureAssignRef(): void
 		]);
 	}
 
+	/**
+	 * @dataProvider dataBug11207
+	 */
+	public function testBug11207(bool $treatPhpDocTypesAsCertain): void
+	{
+		$this->treatPhpDocTypesAsCertain = $treatPhpDocTypesAsCertain;
+		$this->analyse([__DIR__ . '/data/bug-11207.php'], []);
+	}
+
+	public function dataBug11207(): array
+	{
+		return [
+			[true],
+			[false],
+		];
+	}
+
 }

tests/PHPStan/Rules/Pure/data/bug-11207.php

@@ -0,0 +1,38 @@
+<?php // lint >= 8.0
+
+namespace Bug11207;
+
+final class FilterData
+{
+	/**
+	 * @phpstan-pure
+	 */
+	private function __construct(
+		public ?int $type,
+		public bool $hasValue,
+		public mixed $value = null
+	) {
+	}
+
+	/**
+	 * @param array{type?: int|numeric-string|null, value?: mixed} $data
+	 * @phpstan-pure
+	 */
+	public static function fromArray(array $data): self
+	{
+		if (isset($data['type'])) {
+			if (!\is_int($data['type']) && (!\is_string($data['type']) || !is_numeric($data['type']))) {
+				throw new \InvalidArgumentException(sprintf(
+					'The "type" parameter MUST be of type "integer" or "null", "%s" given.',
+					\gettype($data['type'])
+				));
+			}
+
+			$type = (int) $data['type'];
+		} else {
+			$type = null;
+		}
+
+		return new self($type, \array_key_exists('value', $data), $data['value'] ?? null);
+	}
+}