CallTo*Rule: cheap checks first

Author: staabm

src/Rules/Methods/CallToMethodStatementWithNoDiscardRule.php

@@ -59,6 +59,9 @@ public function processNode(Node $node, Scope $scope): array
 		) {
 			return [];
 		}
+		if (!$methodCall->name instanceof Node\Identifier) {
+			return [];
+		}
 
 		if ($methodCall->isFirstClassCallable()) {
 			return [];
@@ -68,11 +71,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$methodCall->name instanceof Node\Identifier) {
-			return [];
-		}
 		$methodName = $methodCall->name->toString();
-
 		$typeResult = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			NullsafeOperatorHelper::getNullsafeShortcircuitedExprRespectingScope($scope, $methodCall->var),

src/Rules/Methods/CallToMethodStatementWithoutSideEffectsRule.php

@@ -38,17 +38,21 @@ public function processNode(Node $node, Scope $scope): array
 		if ($methodCall instanceof Node\Expr\BinaryOp\Pipe) {
 			$methodCall = $methodCall->right;
 		}
+
 		if ($methodCall instanceof Node\Expr\NullsafeMethodCall) {
+			if (!$methodCall->name instanceof Node\Identifier) {
+				return [];
+			}
 			$scope = $scope->filterByTruthyValue(new Node\Expr\BinaryOp\NotIdentical($methodCall->var, new Node\Expr\ConstFetch(new Node\Name('null'))));
-		} elseif (!$methodCall instanceof Node\Expr\MethodCall) {
+		} elseif ($methodCall instanceof Node\Expr\MethodCall) {
+			if (!$methodCall->name instanceof Node\Identifier) {
+				return [];
+			}
+		} else {
 			return [];
 		}
 
-		if (!$methodCall->name instanceof Node\Identifier) {
-			return [];
-		}
 		$methodName = $methodCall->name->toString();
-
 		$typeResult = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			NullsafeOperatorHelper::getNullsafeShortcircuitedExprRespectingScope($scope, $methodCall->var),

src/Rules/Methods/CallToStaticMethodStatementWithNoDiscardRule.php

@@ -60,16 +60,15 @@ public function processNode(Node $node, Scope $scope): array
 		if (!$methodCall instanceof Node\Expr\StaticCall) {
 			return [];
 		}
-
-		if ($methodCall->isFirstClassCallable()) {
+		if (!$methodCall->name instanceof Node\Identifier) {
 			return [];
 		}
 
-		if (!$this->phpVersion->supportsNoDiscardAttribute()) {
+		if ($methodCall->isFirstClassCallable()) {
 			return [];
 		}
 
-		if (!$methodCall->name instanceof Node\Identifier) {
+		if (!$this->phpVersion->supportsNoDiscardAttribute()) {
 			return [];
 		}