Update non-static access rule naming and message

Co-authored-by: Ondřej Mirtes <[email protected]>

Author: jnoordsij

src/Rules/Properties/AccessPropertiesCheck.php

@@ -163,10 +163,10 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
 		if ($propertyReflection->isStatic()) {
 			return [
 				RuleErrorBuilder::message(sprintf(
-					'Non static access to static property %s::$%s.',
+					'Non-static access to static property %s::$%s.',
 					$propertyReflection->getDeclaringClass()->getDisplayName(),
 					$name,
-				))->identifier('property.nonStaticAccess')->build(),
+				))->identifier('staticProperty.nonStaticAccess')->build(),
 			];
 		}
 

tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php

@@ -350,7 +350,7 @@ public function testBug12692(): void
 		$this->checkUnionTypes = false;
 		$this->checkDynamicProperties = false;
 		$this->analyse([__DIR__ . '/data/bug-12692.php'], [[
-			'Non static access to static property Bug12692\Foo::$static.',
+			'Non-static access to static property Bug12692\Foo::$static.',
 			14,
 		]]);
 	}