Rename method

ondrejmirtes · ondrejmirtes · commit e50db5d81b7d · 2025-09-18T09:10:55.000+02:00
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -183,7 +183,7 @@ public function getAttributes(): array
 		return [];
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
 	}
diff --git a/src/Reflection/Dummy/ChangedTypeMethodReflection.php b/src/Reflection/Dummy/ChangedTypeMethodReflection.php
@@ -172,9 +172,9 @@ public function getAttributes(): array
 		return $this->reflection->getAttributes();
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
-		return $this->reflection->hasNoDiscardAttribute();
+		return $this->reflection->mustUseReturnValue();
 	}
 
 }
diff --git a/src/Reflection/Dummy/DummyConstructorReflection.php b/src/Reflection/Dummy/DummyConstructorReflection.php
@@ -157,7 +157,7 @@ public function getAttributes(): array
 		return [];
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		// Align with the getAttributes() returning empty
 		return TrinaryLogic::createNo();
diff --git a/src/Reflection/Dummy/DummyMethodReflection.php b/src/Reflection/Dummy/DummyMethodReflection.php
@@ -149,7 +149,7 @@ public function getAttributes(): array
 		return [];
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		// Align with the getAttributes() returning empty
 		return TrinaryLogic::createNo();
diff --git a/src/Reflection/ExtendedMethodReflection.php b/src/Reflection/ExtendedMethodReflection.php
@@ -67,9 +67,9 @@ public function getAttributes(): array;
 
 	/**
 	 * Has the #[\NoDiscard] attribute - on PHP 8.5+ if the function's return
-	 * value is unused at runtime a warning is emitted, phpstan will emit the
+	 * value is unused at runtime a warning is emitted, PHPStan will emit the
 	 * warning during analysis and on older PHP versions too
 	 */
-	public function hasNoDiscardAttribute(): TrinaryLogic;
+	public function mustUseReturnValue(): TrinaryLogic;
 
 }
diff --git a/src/Reflection/FunctionReflection.php b/src/Reflection/FunctionReflection.php
@@ -64,9 +64,9 @@ public function getAttributes(): array;
 
 	/**
 	 * Has the #[\NoDiscard] attribute - on PHP 8.5+ if the function's return
-	 * value is unused at runtime a warning is emitted, phpstan will emit the
+	 * value is unused at runtime a warning is emitted, PHPStan will emit the
 	 * warning during analysis and on older PHP versions too
 	 */
-	public function hasNoDiscardAttribute(): TrinaryLogic;
+	public function mustUseReturnValue(): TrinaryLogic;
 
 }
diff --git a/src/Reflection/Native/NativeFunctionReflection.php b/src/Reflection/Native/NativeFunctionReflection.php
@@ -151,7 +151,7 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		foreach ($this->attributes as $attrib) {
 			if (strtolower($attrib->getName()) === 'nodiscard') {
diff --git a/src/Reflection/Native/NativeMethodReflection.php b/src/Reflection/Native/NativeMethodReflection.php
@@ -227,7 +227,7 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		foreach ($this->attributes as $attrib) {
 			if (strtolower($attrib->getName()) === 'nodiscard') {
diff --git a/src/Reflection/Php/ClosureCallMethodReflection.php b/src/Reflection/Php/ClosureCallMethodReflection.php
@@ -202,9 +202,9 @@ public function getAttributes(): array
 		return $this->nativeMethodReflection->getAttributes();
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
-		return $this->nativeMethodReflection->hasNoDiscardAttribute();
+		return $this->nativeMethodReflection->mustUseReturnValue();
 	}
 
 }
diff --git a/src/Reflection/Php/EnumCasesMethodReflection.php b/src/Reflection/Php/EnumCasesMethodReflection.php
@@ -161,7 +161,7 @@ public function getAttributes(): array
 		return [];
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
 	}
diff --git a/src/Reflection/Php/ExitFunctionReflection.php b/src/Reflection/Php/ExitFunctionReflection.php
@@ -143,7 +143,7 @@ public function getAttributes(): array
 		return [];
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
 	}
diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -339,7 +339,7 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		foreach ($this->attributes as $attrib) {
 			if (strtolower($attrib->getName()) === 'nodiscard') {
diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -276,7 +276,7 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		foreach ($this->attributes as $attrib) {
 			if (strtolower($attrib->getName()) === 'nodiscard') {
diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -520,7 +520,7 @@ public function getAttributes(): array
 		return $this->attributes;
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		foreach ($this->attributes as $attrib) {
 			if (strtolower($attrib->getName()) === 'nodiscard') {
diff --git a/src/Reflection/ResolvedMethodReflection.php b/src/Reflection/ResolvedMethodReflection.php
@@ -229,9 +229,9 @@ public function getAttributes(): array
 		return $this->reflection->getAttributes();
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
-		return $this->reflection->hasNoDiscardAttribute();
+		return $this->reflection->mustUseReturnValue();
 	}
 
 }
diff --git a/src/Reflection/Type/IntersectionTypeMethodReflection.php b/src/Reflection/Type/IntersectionTypeMethodReflection.php
@@ -228,9 +228,9 @@ public function getAttributes(): array
 		return $this->methods[0]->getAttributes();
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
-		return TrinaryLogic::lazyMaxMin($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->hasNoDiscardAttribute());
+		return TrinaryLogic::lazyMaxMin($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->mustUseReturnValue());
 	}
 
 }
diff --git a/src/Reflection/Type/UnionTypeMethodReflection.php b/src/Reflection/Type/UnionTypeMethodReflection.php
@@ -205,9 +205,9 @@ public function getAttributes(): array
 		return $this->methods[0]->getAttributes();
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
-		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->hasNoDiscardAttribute());
+		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->mustUseReturnValue());
 	}
 
 }
diff --git a/src/Reflection/WrappedExtendedMethodReflection.php b/src/Reflection/WrappedExtendedMethodReflection.php
@@ -173,7 +173,7 @@ public function getAttributes(): array
 		return [];
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
 		// Align with the getAttributes() returning empty
 		return TrinaryLogic::createNo();
diff --git a/src/Rules/FunctionDefinitionCheck.php b/src/Rules/FunctionDefinitionCheck.php
@@ -494,7 +494,7 @@ private function checkParametersAcceptor(
 					->build();
 			}
 		}
-		if ($parametersAcceptor->hasNoDiscardAttribute()->yes()) {
+		if ($parametersAcceptor->mustUseReturnValue()->yes()) {
 			$returnType = $functionNode->getReturnType();
 			if ($returnType instanceof Identifier
 				&& $returnType->name === 'void'
diff --git a/src/Rules/Functions/CallToFunctionStatementWithNoDiscardRule.php b/src/Rules/Functions/CallToFunctionStatementWithNoDiscardRule.php
@@ -43,7 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$function = $this->reflectionProvider->getFunction($funcCall->name, $scope);
 
-		if (!$function->hasNoDiscardAttribute()->yes()) {
+		if (!$function->mustUseReturnValue()->yes()) {
 			return [];
 		}
 
diff --git a/src/Rules/Methods/CallToMethodStatementWithNoDiscardRule.php b/src/Rules/Methods/CallToMethodStatementWithNoDiscardRule.php
@@ -63,7 +63,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$method = $calledOnType->getMethod($methodName, $scope);
 
-		if (!$method->hasNoDiscardAttribute()->yes()) {
+		if (!$method->mustUseReturnValue()->yes()) {
 			return [];
 		}
 
diff --git a/src/Rules/Methods/CallToStaticMethodStatementWithNoDiscardRule.php b/src/Rules/Methods/CallToStaticMethodStatementWithNoDiscardRule.php
@@ -76,7 +76,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$method = $calledOnType->getMethod($methodName, $scope);
 
-		if (!$method->hasNoDiscardAttribute()->yes()) {
+		if (!$method->mustUseReturnValue()->yes()) {
 			return [];
 		}
 
diff --git a/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php b/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php
@@ -145,9 +145,9 @@ public function hasSideEffects(): TrinaryLogic
 		return $this->methodReflection->hasSideEffects();
 	}
 
-	public function hasNoDiscardAttribute(): TrinaryLogic
+	public function mustUseReturnValue(): TrinaryLogic
 	{
-		return $this->methodReflection->hasNoDiscardAttribute();
+		return $this->methodReflection->mustUseReturnValue();
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ public function getAttributes(): array`
`183`	`183`	`return [];`
`184`	`184`	`}`
`185`	`185`
`186`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`186`	`+ public function mustUseReturnValue(): TrinaryLogic`
`187`	`187`	`{`
`188`	`188`	`return TrinaryLogic::createNo();`
`189`	`189`	`}`
Original file line number	Diff line number	Diff line change
`@@ -172,9 +172,9 @@ public function getAttributes(): array`
`172`	`172`	`return $this->reflection->getAttributes();`
`173`	`173`	`}`
`174`	`174`
`175`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`175`	`+ public function mustUseReturnValue(): TrinaryLogic`
`176`	`176`	`{`
`177`		`- return $this->reflection->hasNoDiscardAttribute();`
	`177`	`+ return $this->reflection->mustUseReturnValue();`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`}`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ public function getAttributes(): array`
`157`	`157`	`return [];`
`158`	`158`	`}`
`159`	`159`
`160`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`160`	`+ public function mustUseReturnValue(): TrinaryLogic`
`161`	`161`	`{`
`162`	`162`	`// Align with the getAttributes() returning empty`
`163`	`163`	`return TrinaryLogic::createNo();`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ public function getAttributes(): array`
`149`	`149`	`return [];`
`150`	`150`	`}`
`151`	`151`
`152`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`152`	`+ public function mustUseReturnValue(): TrinaryLogic`
`153`	`153`	`{`
`154`	`154`	`// Align with the getAttributes() returning empty`
`155`	`155`	`return TrinaryLogic::createNo();`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ public function getAttributes(): array`
`151`	`151`	`return $this->attributes;`
`152`	`152`	`}`
`153`	`153`
`154`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`154`	`+ public function mustUseReturnValue(): TrinaryLogic`
`155`	`155`	`{`
`156`	`156`	`foreach ($this->attributes as $attrib) {`
`157`	`157`	`if (strtolower($attrib->getName()) === 'nodiscard') {`
Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ public function getAttributes(): array`
`227`	`227`	`return $this->attributes;`
`228`	`228`	`}`
`229`	`229`
`230`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`230`	`+ public function mustUseReturnValue(): TrinaryLogic`
`231`	`231`	`{`
`232`	`232`	`foreach ($this->attributes as $attrib) {`
`233`	`233`	`if (strtolower($attrib->getName()) === 'nodiscard') {`
Original file line number	Diff line number	Diff line change
`@@ -202,9 +202,9 @@ public function getAttributes(): array`
`202`	`202`	`return $this->nativeMethodReflection->getAttributes();`
`203`	`203`	`}`
`204`	`204`
`205`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`205`	`+ public function mustUseReturnValue(): TrinaryLogic`
`206`	`206`	`{`
`207`		`- return $this->nativeMethodReflection->hasNoDiscardAttribute();`
	`207`	`+ return $this->nativeMethodReflection->mustUseReturnValue();`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ public function getAttributes(): array`
`161`	`161`	`return [];`
`162`	`162`	`}`
`163`	`163`
`164`		`- public function hasNoDiscardAttribute(): TrinaryLogic`
	`164`	`+ public function mustUseReturnValue(): TrinaryLogic`
`165`	`165`	`{`
`166`	`166`	`return TrinaryLogic::createNo();`
`167`	`167`	`}`