fixup! Replace error-prone instanceof in Rules classes

Author: zonuexe

src/Rules/PhpDoc/RequireImplementsDefinitionTraitRule.php

@@ -10,6 +10,8 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\VerbosityLevel;
+use function array_column;
+use function array_map;
 use function array_merge;
 use function count;
 use function sprintf;
@@ -49,35 +51,38 @@ public function processNode(Node $node, Scope $scope): array
 		$errors = [];
 		foreach ($implementsTags as $implementsTag) {
 			$type = $implementsTag->getType();
-			$classNames = $type->getObjectClassNames();
-			if (count($classNames) === 0) {
+			if (count($type->getObjectClassNames()) === 0) {
 				$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-implements contains non-object type %s.', $type->describe(VerbosityLevel::typeOnly())))
 					->identifier('requireImplements.nonObject')
 					->build();
 				continue;
 			}
 
-			$class = $classNames[0];
-			$referencedClassReflection = $type->getObjectClassReflections()[0] ?? null;
-			if ($referencedClassReflection === null) {
-				$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-implements contains unknown class %s.', $class))
-					->discoveringSymbolsTip()
-					->identifier('class.notFound')
-					->build();
-				continue;
-			}
+			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
+			$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
+			foreach ($type->getObjectClassNames() as $class) {
+				$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;
+				if ($referencedClassReflection === null) {
+					$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-implements contains unknown class %s.', $class))
+						->discoveringSymbolsTip()
+						->identifier('class.notFound')
+						->build();
+					continue;
+				}
+
+				if (!$referencedClassReflection->isInterface()) {
+					$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-implements cannot contain non-interface type %s.', $class))
+						->identifier(sprintf('requireImplements.%s', strtolower($referencedClassReflection->getClassTypeDescription())))
+						->build();
+				} else {
+					$errors = array_merge(
+						$errors,
+						$this->classCheck->checkClassNames([
+							new ClassNameNodePair($class, $node),
+						], $this->checkClassCaseSensitivity),
+					);
+				}
 
-			if (!$referencedClassReflection->isInterface()) {
-				$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-require-implements cannot contain non-interface type %s.', $class))
-					->identifier(sprintf('requireImplements.%s', strtolower($referencedClassReflection->getClassTypeDescription())))
-					->build();
-			} else {
-				$errors = array_merge(
-					$errors,
-					$this->classCheck->checkClassNames([
-						new ClassNameNodePair($class, $node),
-					], $this->checkClassCaseSensitivity),
-				);
 			}
 		}