Avoid false positif in_array always true

Author: VincentLanglet

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

@@ -157,6 +157,11 @@ public function findSpecifiedType(
 											continue;
 										}
 
+										$haystackArrayValueConstantScalarTypes = $haystackArrayValueType->getConstantScalarTypes();
+										if (count($haystackArrayValueConstantScalarTypes) > 1) {
+											continue;
+										}
+
 										foreach ($haystackArrayValueType->getConstantScalarTypes() as $constantScalarType) {
 											if ($constantScalarType->isSuperTypeOf($needleType)->yes()) {
 												continue 3;

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -981,4 +981,10 @@ public function testBugPR3404(): void
 		]);
 	}
 
+	public function testBug13151(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-13151.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-13151.php

@@ -0,0 +1,28 @@
+<?php declare(strict_types = 1);
+
+namespace Bug13151;
+
+class HelloWorld
+{
+	/**
+	 * @return array{a:0|1, b:0|1, c:0|1}
+	 */
+	public function extractAsArray(): array
+	{
+		return [
+			'a' => 1,
+			'b' => 1,
+			'c' => 1
+		];
+	}
+
+	public function test(): void
+	{
+		echo in_array(0, $this->extractAsArray(), true) ? "True" : "False";
+	}
+
+	public function test2(): void
+	{
+		echo in_array(0, $this->extractAsArray()) ? "True" : "False";
+	}
+}