Add incorrect non static access of static property to AccessPropertiesRuleTest

Author: jnoordsij

tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php

@@ -39,140 +39,140 @@ public function testAccessProperties(): void
 			[
 				[
 					'Access to an undefined property TestAccessProperties\BarAccessProperties::$loremipsum.',
-					24,
+					26,
 					$tipText,
 				],
 				[
 					'Access to private property $foo of parent class TestAccessProperties\FooAccessProperties.',
-					25,
+					27,
 				],
 				[
 					'Cannot access property $propertyOnString on string.',
-					32,
+					35,
 				],
 				[
 					'Access to private property TestAccessProperties\FooAccessProperties::$foo.',
-					43,
+					46,
 				],
 				[
 					'Access to protected property TestAccessProperties\FooAccessProperties::$bar.',
-					44,
+					47,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$baz.',
-					50,
+					53,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$nonexistent.',
-					53,
+					56,
 					$tipText,
 				],
 				[
 					'Access to private property TestAccessProperties\FooAccessProperties::$foo.',
-					59,
+					62,
 				],
 				[
 					'Access to protected property TestAccessProperties\FooAccessProperties::$bar.',
-					60,
+					63,
 				],
 				[
 					'Access to property $foo on an unknown class TestAccessProperties\UnknownClass.',
-					64,
+					67,
 					'Learn more at https://phpstan.org/user-guide/discovering-symbols',
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$emptyBaz.',
-					69,
+					72,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$emptyNonexistent.',
-					71,
+					74,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherNonexistent.',
-					77,
+					80,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherNonexistent.',
-					78,
+					81,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherEmptyNonexistent.',
-					81,
+					84,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherEmptyNonexistent.',
-					84,
+					87,
 					$tipText,
 				],
 				[
 					'Access to property $test on an unknown class TestAccessProperties\FirstUnknownClass.',
-					147,
+					150,
 					'Learn more at https://phpstan.org/user-guide/discovering-symbols',
 				],
 				[
 					'Access to property $test on an unknown class TestAccessProperties\SecondUnknownClass.',
-					147,
+					150,
 					'Learn more at https://phpstan.org/user-guide/discovering-symbols',
 				],
 				[
 					'Access to an undefined property TestAccessProperties\WithFooAndBarProperty|TestAccessProperties\WithFooProperty::$bar.',
-					177,
+					180,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\SomeInterface&TestAccessProperties\WithFooProperty::$bar.',
-					194,
+					197,
 					$tipText,
 				],
 				[
 					'Cannot access property $ipsum on TestAccessProperties\FooAccessProperties|null.',
-					208,
+					211,
 				],
 				[
 					'Cannot access property $foo on null.',
-					221,
+					224,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$lorem.',
-					248,
+					251,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$dolor.',
-					251,
+					254,
 					$tipText,
 				],
 				[
 					'Cannot access property $bar on TestAccessProperties\NullCoalesce|null.',
-					274,
+					277,
 				],
 				[
 					'Cannot access property $foo on TestAccessProperties\NullCoalesce|null.',
-					274,
+					277,
 				],
 				[
 					'Cannot access property $foo on TestAccessProperties\NullCoalesce|null.',
-					274,
+					277,
 				],
 				[
-					'Access to an undefined property class@anonymous/tests/PHPStan/Rules/Properties/data/access-properties.php:297::$barProperty.',
-					302,
+					'Access to an undefined property class@anonymous/tests/PHPStan/Rules/Properties/data/access-properties.php:300::$barProperty.',
+					305,
 					$tipText,
 				],
 				[
 					'Cannot access property $selfOrNull on TestAccessProperties\RevertNonNullabilityForIsset|null.',
-					407,
+					410,
 				],
 				[
 					'Access to an undefined property object::$baz.',
-					438,
+					441,
 					$tipText,
 				],
 			],
@@ -191,114 +191,114 @@ public function testAccessPropertiesWithoutUnionTypes(): void
 			[
 				[
 					'Access to an undefined property TestAccessProperties\BarAccessProperties::$loremipsum.',
-					24,
+					26,
 					$tipText,
 				],
 				[
 					'Access to private property $foo of parent class TestAccessProperties\FooAccessProperties.',
-					25,
+					27,
 				],
 				[
 					'Cannot access property $propertyOnString on string.',
-					32,
+					35,
 				],
 				[
 					'Access to private property TestAccessProperties\FooAccessProperties::$foo.',
-					43,
+					46,
 				],
 				[
 					'Access to protected property TestAccessProperties\FooAccessProperties::$bar.',
-					44,
+					47,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$baz.',
-					50,
+					53,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$nonexistent.',
-					53,
+					56,
 					$tipText,
 				],
 				[
 					'Access to private property TestAccessProperties\FooAccessProperties::$foo.',
-					59,
+					62,
 				],
 				[
 					'Access to protected property TestAccessProperties\FooAccessProperties::$bar.',
-					60,
+					63,
 				],
 				[
 					'Access to property $foo on an unknown class TestAccessProperties\UnknownClass.',
-					64,
+					67,
 					'Learn more at https://phpstan.org/user-guide/discovering-symbols',
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$emptyBaz.',
-					69,
+					72,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$emptyNonexistent.',
-					71,
+					74,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherNonexistent.',
-					77,
+					80,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherNonexistent.',
-					78,
+					81,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherEmptyNonexistent.',
-					81,
+					84,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$anotherEmptyNonexistent.',
-					84,
+					87,
 					$tipText,
 				],
 				[
 					'Access to property $test on an unknown class TestAccessProperties\FirstUnknownClass.',
-					147,
+					150,
 					'Learn more at https://phpstan.org/user-guide/discovering-symbols',
 				],
 				[
 					'Access to property $test on an unknown class TestAccessProperties\SecondUnknownClass.',
-					147,
+					150,
 					'Learn more at https://phpstan.org/user-guide/discovering-symbols',
 				],
 				[
 					'Access to an undefined property TestAccessProperties\SomeInterface&TestAccessProperties\WithFooProperty::$bar.',
-					194,
+					197,
 					$tipText,
 				],
 				[
 					'Cannot access property $foo on null.',
-					221,
+					224,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$lorem.',
-					248,
+					251,
 					$tipText,
 				],
 				[
 					'Access to an undefined property TestAccessProperties\FooAccessProperties::$dolor.',
-					251,
+					254,
 					$tipText,
 				],
 				[
 					'Cannot access property $bar on TestAccessProperties\NullCoalesce|null.',
-					274,
+					277,
 				],
 				[
-					'Access to an undefined property class@anonymous/tests/PHPStan/Rules/Properties/data/access-properties.php:297::$barProperty.',
-					302,
+					'Access to an undefined property class@anonymous/tests/PHPStan/Rules/Properties/data/access-properties.php:300::$barProperty.',
+					305,
 					$tipText,
 				],
 			],
@@ -333,12 +333,12 @@ public function testAccessPropertiesOnThisOnly(): void
 			[
 				[
 					'Access to an undefined property TestAccessProperties\BarAccessProperties::$loremipsum.',
-					24,
+					26,
 					$tipText,
 				],
 				[
 					'Access to private property $foo of parent class TestAccessProperties\FooAccessProperties.',
-					25,
+					27,
 				],
 			],
 		);

tests/PHPStan/Rules/Properties/data/access-properties.php

@@ -12,6 +12,8 @@ class FooAccessProperties
 
 	public $ipsum;
 
+	public static $staticFoo;
+
 }
 
 class BarAccessProperties extends FooAccessProperties
@@ -23,6 +25,7 @@ public function foo()
 	{
 		$this->loremipsum; // nonexistent
 		$this->foo; // private from an ancestor
+		$this->staticFoo;
 		$this->bar;
 		$this->ipsum;
 		$this->foobar;