fix expectations

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -3296,7 +3296,7 @@ static function (): void {
 			return new ExpressionResult(
 				$leftMergedWithRightScope,
 				$leftResult->hasYield() || $rightResult->hasYield(),
-				$leftResult->isAlwaysTerminating() || $rightResult->isAlwaysTerminating(),
+				$leftResult->isAlwaysTerminating(),
 				array_merge($leftResult->getThrowPoints(), $rightResult->getThrowPoints()),
 				array_merge($leftResult->getImpurePoints(), $rightResult->getImpurePoints()),
 				static fn (): MutatingScope => $rightResult->getScope()->filterByTruthyValue($expr),
@@ -3704,15 +3704,13 @@ static function (Node $node, Scope $scope) use ($nodeCallback): void {
 				$ifResult = $this->processExprNode($stmt, $expr->if, $ifTrueScope, $nodeCallback, $context);
 				$throwPoints = array_merge($throwPoints, $ifResult->getThrowPoints());
 				$impurePoints = array_merge($impurePoints, $ifResult->getImpurePoints());
-				$isAlwaysTerminating = $isAlwaysTerminating || $ifResult->isAlwaysTerminating();
 				$ifTrueScope = $ifResult->getScope();
 				$ifTrueType = $ifTrueScope->getType($expr->if);
 			}
 
 			$elseResult = $this->processExprNode($stmt, $expr->else, $ifFalseScope, $nodeCallback, $context);
 			$throwPoints = array_merge($throwPoints, $elseResult->getThrowPoints());
 			$impurePoints = array_merge($impurePoints, $elseResult->getImpurePoints());
-			$isAlwaysTerminating = $isAlwaysTerminating || $elseResult->isAlwaysTerminating();
 			$ifFalseScope = $elseResult->getScope();
 
 			$condType = $scope->getType($expr->cond);
@@ -4806,7 +4804,7 @@ private function processArrowFunctionNode(
 		$nodeCallback(new InArrowFunctionNode($arrowFunctionType, $expr), $arrowFunctionScope);
 		$exprResult = $this->processExprNode($stmt, $expr->expr, $arrowFunctionScope, $nodeCallback, ExpressionContext::createTopLevel());
 
-		return new ExpressionResult($scope, false, $exprResult->isAlwaysTerminating(), $exprResult->getThrowPoints(), $exprResult->getImpurePoints());
+		return new ExpressionResult($scope, false, false, $exprResult->getThrowPoints(), $exprResult->getImpurePoints());
 	}
 
 	/**

tests/PHPStan/Analyser/ExpressionResultTest.php

@@ -72,23 +72,23 @@ public static function dataIsAlwaysTerminating(): array
 			],
 			[
 				'$x ? "abc" : exit();',
-				true,
+				false,
 			],
 			[
 				'$x ? exit() : "abc";',
-				true,
+				false,
 			],
 			[
 				'fn() => yield (exit());',
-				true,
+				false,
 			],
 			[
 				'@exit();',
 				true,
 			],
 			[
 				'$x && exit();',
-				true,
+				false,
 			],
 			[
 				'exit() && $x;',