Fixed false-positive with by-ref parameters and array-functions

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -5487,6 +5487,7 @@ private function processAssignVar(
 			$nativeValueToWrite = $scope->getNativeType($assignedExpr);
 			$originalValueToWrite = $valueToWrite;
 			$originalNativeValueToWrite = $nativeValueToWrite;
+			$scopeBeforeAssignEval = $scope;
 
 			// 3. eval assigned expr
 			$result = $processExprCallback($scope);
@@ -5542,11 +5543,11 @@ private function processAssignVar(
 
 			if ($varType->isArray()->yes() || !(new ObjectType(ArrayAccess::class))->isSuperTypeOf($varType)->yes()) {
 				if ($var instanceof Variable && is_string($var->name)) {
-					$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr), $scope);
+					$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr), $scopeBeforeAssignEval);
 					$scope = $scope->assignVariable($var->name, $valueToWrite, $nativeValueToWrite, TrinaryLogic::createYes());
 				} else {
 					if ($var instanceof PropertyFetch || $var instanceof StaticPropertyFetch) {
-						$nodeCallback(new PropertyAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scope);
+						$nodeCallback(new PropertyAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scopeBeforeAssignEval);
 						if ($var instanceof PropertyFetch && $var->name instanceof Node\Identifier && !$isAssignOp) {
 							$scope = $scope->assignInitializedProperty($scope->getType($var->var), $var->name->toString());
 						}

tests/PHPStan/Rules/Variables/ParameterOutAssignedTypeRuleTest.php

@@ -64,4 +64,9 @@ public function testBenevolentArrayKey(): void
 		$this->analyse([__DIR__ . '/data/benevolent-array-key.php'], []);
 	}
 
+	public function testBug13093(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13093.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Variables/data/bug-13093.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Bug13093;
+
+use function array_shift;
+use function count;
+use Generator;
+use function PHPStan\debugScope;
+use function PHPStan\dumpType;
+
+class MutantProcessContainer {}
+
+final class ParallelProcessRunner
+{
+	/**
+	 * @var array<int, MutantProcessContainer>
+	 */
+	private array $nextMutantProcessKillerContainer = [];
+
+	/**
+	 * @param MutantProcessContainer[] $bucket
+	 * @param Generator<MutantProcessContainer> $input
+	 */
+	public function fillBucketOnce(array &$bucket, Generator $input, int $threadCount): int
+	{
+		if (count($bucket) >= $threadCount || !$input->valid()) {
+			if ($this->nextMutantProcessKillerContainer !== []) {
+				$bucket[] = array_shift($this->nextMutantProcessKillerContainer);
+			}
+
+			return 0;
+		}
+
+		return 1;
+	}
+
+}
+