Fix "Offset X might not exist on..." in UnionTypeTest/IntersectionTypeTest

Author: staabm

tests/PHPStan/Type/IntersectionTypeTest.php

@@ -5,6 +5,7 @@
 use DoctrineIntersectionTypeIsSupertypeOf\Collection;
 use Iterator;
 use ObjectTypeEnums\FooEnum;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Testing\PHPStanTestCase;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Accessory\AccessoryArrayListType;
@@ -398,6 +399,9 @@ public function testGetEnumCases(
 		$enumCases = $type->getEnumCases();
 		$this->assertCount(count($expectedEnumCases), $enumCases);
 		foreach ($enumCases as $i => $enumCase) {
+			if (!array_key_exists($i, $expectedEnumCases)) {
+				throw new ShouldNotHappenException();
+			}
 			$expectedEnumCase = $expectedEnumCases[$i];
 			$this->assertTrue($expectedEnumCase->equals($enumCase), sprintf('%s->equals(%s)', $expectedEnumCase->describe(VerbosityLevel::precise()), $enumCase->describe(VerbosityLevel::precise())));
 		}

tests/PHPStan/Type/UnionTypeTest.php

@@ -8,6 +8,7 @@
 use Iterator;
 use PHPStan\Reflection\Native\NativeParameterReflection;
 use PHPStan\Reflection\PassedByReference;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Testing\PHPStanTestCase;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Accessory\AccessoryLiteralStringType;
@@ -33,6 +34,7 @@
 use function array_merge;
 use function array_reverse;
 use function get_class;
+use function PHPStan\dumpType;
 use function sprintf;
 use const PHP_VERSION_ID;
 
@@ -180,6 +182,12 @@ public static function dataIsSuperTypeOf(): Iterator
 			new IntegerType(),
 			new StringType(),
 		]);
+		if (
+			!isset($unionTypeA->getTypes()[0])
+			|| !isset($unionTypeA->getTypes()[1])
+		) {
+			throw new ShouldNotHappenException();
+		}
 
 		yield [
 			$unionTypeA,
@@ -266,6 +274,12 @@ public static function dataIsSuperTypeOf(): Iterator
 			]),
 			new ArrayType(new MixedType(), new ObjectType('DatePeriod')),
 		]);
+		if (
+			!isset($unionTypeB->getTypes()[0])
+			|| !isset($unionTypeB->getTypes()[1])
+		) {
+			throw new ShouldNotHappenException();
+		}
 
 		yield [
 			$unionTypeB,
@@ -477,6 +491,12 @@ public static function dataIsSubTypeOf(): Iterator
 			new IntegerType(),
 			new StringType(),
 		]);
+		if (
+			!isset($unionTypeA->getTypes()[0])
+			|| !isset($unionTypeA->getTypes()[1])
+		) {
+			throw new ShouldNotHappenException();
+		}
 
 		yield [
 			$unionTypeA,
@@ -570,6 +590,12 @@ public static function dataIsSubTypeOf(): Iterator
 			]),
 			new ArrayType(new MixedType(), new ObjectType('Item')),
 		]);
+		if (
+			!isset($unionTypeB->getTypes()[0])
+			|| !isset($unionTypeB->getTypes()[1])
+		) {
+			throw new ShouldNotHappenException();
+		}
 
 		yield [
 			$unionTypeB,