better error message

Author: staabm

src/Rules/Properties/PropertyInClassRule.php

@@ -37,7 +37,7 @@ public function processNode(Node $node, Scope $scope): array
 			&& !$this->phpVersion->supportsFinalProperties()
 		) {
 			return [
-				RuleErrorBuilder::message('Property cannot be final.')
+				RuleErrorBuilder::message('Final Properties are supported only on PHP 8.4 and later.')
 					->nonIgnorable()
 					->identifier('property.final')
 					->build(),

tests/PHPStan/Rules/Properties/PropertyInClassRuleTest.php

@@ -242,9 +242,20 @@ public function testPhp84AndAbstractFinalHookedProperties(): void
 				'Property cannot be both abstract and final.',
 				7,
 			],
+		]);
+	}
+
+	public function testPhp84AndAbstractFinalHookedPropertiesParseError(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4 or later.');
+		}
+
+		// errors when parsing with php-parser, see https://github.com/nikic/PHP-Parser/issues/1071
+		$this->analyse([__DIR__ . '/data/abstract-final-property-hook-parse-error.php'], [
 			[
-				'Property cannot be both abstract and final.',
-				11,
+				'Cannot use the final modifier on an abstract class member on line 7',
+				7,
 			],
 		]);
 	}
@@ -271,15 +282,15 @@ public function testBeforePhp84FinalProperties(): void
 
 		$this->analyse([__DIR__ . '/data/final-properties.php'], [
 			[
-				'Property cannot be final.',
+				'Final Properties are supported only on PHP 8.4 and later.',
 				7,
 			],
 			[
-				'Property cannot be final.',
+				'Final Properties are supported only on PHP 8.4 and later.',
 				8,
 			],
 			[
-				'Property cannot be final.',
+				'Final Properties are supported only on PHP 8.4 and later.',
 				9,
 			],
 		]);

tests/PHPStan/Rules/Properties/data/abstract-final-property-hook-parse-error.php

@@ -0,0 +1,10 @@
+<?php // lint >= 8.4
+
+namespace AbstractFinalHookParseError;
+
+abstract class User
+{
+	final abstract public string $bar {
+		get;
+	}
+}

tests/PHPStan/Rules/Properties/data/abstract-final-property-hook.php

@@ -7,8 +7,4 @@ abstract class User
 	abstract public string $foo {
 		final get;
 	}
-
-	final abstract public string $bar {
-		get;
-	}
 }