Treat Redis::connect as non-deterministic

Author: vrana

bin/functionMetadata_original.php

@@ -170,6 +170,10 @@
 	'DateTimeImmutable::getTimestamp' => ['hasSideEffects' => false],
 	'DateTimeImmutable::getTimezone' => ['hasSideEffects' => false],
 
+	// affects isConnected()
+	'Redis::connect' => ['hasSideEffects' => true],
+	'Redis::pconnect' => ['hasSideEffects' => true],
+
 	'SplDoublyLinkedList::pop' => ['hasSideEffects' => true],
 	'SplDoublyLinkedList::shift' => ['hasSideEffects' => true],
 

resources/functionMetadata.php

@@ -452,6 +452,8 @@
 	'NumberFormatter::getPattern' => ['hasSideEffects' => false],
 	'NumberFormatter::getSymbol' => ['hasSideEffects' => false],
 	'NumberFormatter::getTextAttribute' => ['hasSideEffects' => false],
+	'Redis::connect' => ['hasSideEffects' => true],
+	'Redis::pconnect' => ['hasSideEffects' => true],
 	'ReflectionAttribute::getArguments' => ['hasSideEffects' => false],
 	'ReflectionAttribute::getName' => ['hasSideEffects' => false],
 	'ReflectionAttribute::getTarget' => ['hasSideEffects' => false],

tests/PHPStan/Rules/TooWideTypehints/TooWidePropertyTypeRuleTest.php

@@ -106,4 +106,10 @@ public function testBug13384bOff(): void
 		$this->analyse([__DIR__ . '/data/bug-13384b.php'], []);
 	}
 
+	public function testBugPR4318()
+	{
+		$this->reportTooWideBool = true;
+		$this->analyse([__DIR__ . '/data/bug-pr-4318.php'], []);
+	}
+
 }

tests/PHPStan/Rules/TooWideTypehints/data/bug-pr-4318.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace BugPR4318;
+
+class Client
+{
+	private bool $isConnected = false;
+
+	public function connect(): void
+	{
+		$driver = new \Redis();
+
+		if ($driver->isConnected()) {
+			return;
+		}
+
+		$driver->connect('');
+		$this->isConnected = $driver->isConnected();
+		echo $this->isConnected;
+	}
+
+}