RegexArrayShapeMatcher - Fix PREG_UNMATCHED_AS_NULL with optional leading groups #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//cc @Seldaek |
|
This pull request has been marked as ready for review. |
staabm
commented
Jul 14, 2024
| | (?# the alternation making it so that only either should match) | ||
| git@([^:]+):/? (?# group 2 here can be null if group 1 matches) | ||
| ) | ||
| (?# removing what follows makes the two first groups nullable, although it then has group 2 unsettable which looks buggy too as PREG_UNMATCHED_AS_NULL is present) |
There was a problem hiding this comment.
@Seldaek not sure what this means. could you come up with a concrete code sample and assertions for it?
(sounds unrelated to the other bugs and might be worth a separate report)
There was a problem hiding this comment.
I just meant if you delete the lines of regex below this comment, then the type of the groups 1 and 2 become correct.
There was a problem hiding this comment.
I see thanks. I will remove the comment from the test so it not confuses others :)
Seldaek
approved these changes
Jul 14, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#11331