More precise intval and floatval signature #4152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Jul 24, 2025
VincentLanglet
force-pushed
the
fix/6560
branch
from
31cd24e to
76e00dc
Compare
ondrejmirtes
requested changes
Sep 7, 2025
There was a problem hiding this comment.
Looking at https://phpstan.org/r/62904f7f-1538-422c-a6c4-f3fb53fc40a4 I don't think this is enough. We should have regression test in both CallToFunctionParametersRuleTest and InvalidCastRuleTest making sure they behave the same.
The pr wasn't good at all, I reworked it with #4314. And the whole issue is not closed yet indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1005
Closes phpstan/phpstan#6560
This will give the same behavior for cast vs intval/floatval functions in
https://phpstan.org/r/850196c1-5f6c-479d-a25a-dd303e9cd047
Not sure if it's worth a non-regression test... should I write a test to expect all the
[argument.type](https://phpstan.org/error-identifiers/argument.type)errors ?