Skip to content

Fix SimpleXMLElement::offsetSet #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

Fix SimpleXMLElement::offsetSet #4196

merged 1 commit into from
Sep 2, 2025

Conversation

VincentLanglet
Copy link
Contributor

VincentLanglet
VincentLanglet commented Aug 1, 2025
View reviewed changes
stubs/iterable.stub

/**
* @param int|string $key
* @param self|string|int|float|bool $value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept consistency with

phpstan-src/src/Reflection/Php/SimpleXMLElementProperty.php

Lines 79 to 88 in 9dbff97

public function getWritableType(): Type
{
return TypeCombinator::union(
$this->type,
new IntegerType(),
new FloatType(),
new StringType(),
new BooleanType(),
);
}

@ondrejmirtes ondrejmirtes merged commit 1ac1259 into phpstan:2.1.x Sep 2, 2025
449 of 454 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SimpleXMLElement Should Accept String

2 participants

@VincentLanglet @ondrejmirtes