do not skip Generator for MissingTypehintCheck #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
2 times, most recently
from
ebcdd50 to
1dc38d3
Compare
|
Explained the wanted changes here phpstan/phpstan#7498 (comment) |
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
from
1dc38d3 to
24bbb81
Compare
|
I would love to this moving forward. Are you still interested in your PR @Flyingmana ? I think you just need to
|
|
Yes, might have time for it later today, but latest next weekend |
# Conflicts: # conf/bleedingEdge.neon # conf/config.neon # conf/parametersSchema.neon
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
3 times, most recently
from
e47243b to
ac69196
Compare
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
from
ac69196 to
e262f13
Compare
Flyingmana
commented
Sep 14, 2025
|
I think now all is fixed which belongs to this repository, the rest is separate repositories |
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Sep 15, 2025
| } | ||
| if (in_array($classReflection->getName(), self::ITERABLE_GENERIC_CLASS_NAMES, true)) { | ||
| if ( | ||
| $this->checkGenericIterableClasses !== true && |
There was a problem hiding this comment.
Please do !$this->checkGenericIterableClasses instead
| MissingTypehintCheck::MISSING_ITERABLE_VALUE_TYPE_TIP, | ||
| ], | ||
| [ | ||
| 'Function MissingFunctionParameterTypehint\missingTraversableTypehint() has parameter $traversable with generic interface Traversable but does not specify its types: TKey, TValu', |
There was a problem hiding this comment.
Pretty sure this will fail with a typo - TValu vs. TValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #7498
only a draft for now, I want to see which test are all failing and for what reasons.