Fix wrong inference on preg_match != false #4223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Aug 8, 2025
| @@ -30,7 +30,7 @@ public function sayHello3(string $s): void | |||
| public function sayHello4(string $s): void | |||
| { | |||
| if (preg_match('/data-(\d{6})\.json$/', $s, $matches) <= 0) { | |||
| assertType('array{}', $matches); | |||
| assertType('list{0?: string, 1?: non-falsy-string&numeric-string}', $matches); | |||
There was a problem hiding this comment.
This might be considered as a "regression" but:
- The main goal of the issue 11293 was the inference line 38
- It will be consistent with
== 0check https://phpstan.org/r/fb9edc94-e56a-4e9e-8270-a6ae06570bb1
BTW array{} is already technically not true since if preg_match return false, $matches is null.
|
Ondrey wanted this problem solved via a more general approach - see #3881 |
|
Thank you! I'd like improvements to TypeSpecifierContext but we already have many hardcoded fixes in TypeSpecifier so this is just one more. It can be refactored later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11708
Closes phpstan/phpstan#11908
cc @staabm