relax strict printf parameter check #4400
Merged
+17
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I relaxed the strict printf parameter check as described in this comment.
IMO
checkStrictPrintfPlaceholderTypes: trueshould mean precisely the level of strictness that's appropriate for phpstan-strict-rules.Beyond that it may be desirable to configure it to be more/less strict. But for now, those who want it less strict will have to set it to
falseand they will be no worse off than before I introduced it. Those who want it more strict can keep it turned on and they'll be at least somewhat better off than before I introduced it.