Variables set in foreach that's always looped thanks to non-empty arrays cannot be used after the loop

Author: ondrejmirtes

README.md

@@ -15,6 +15,7 @@
   * `array_keys` (3rd parameter; only if the 2nd parameter `$search_value` is provided)
   * `base64_decode` (2nd parameter)
 * Variables assigned in `while` loop condition and `for` loop initial assignment cannot be used after the loop.
+* Variables set in foreach that's always looped thanks to non-empty arrays cannot be used after the loop.
 * Types in `switch` condition and `case` value must match. PHP compares them loosely by default and that can lead to unexpected results.
 * Statically declared methods are called statically.
 * Disallow `empty()` - it's a very loose comparison (see [manual](https://php.net/empty)), it's recommended to use more strict one.

rules.neon

@@ -1,5 +1,6 @@
 parameters:
 	polluteScopeWithLoopInitialAssignments: false
+	polluteScopeWithAlwaysIterableForeach: false
 	checkAlwaysTrueCheckTypeFunctionCall: true
 	checkAlwaysTrueInstanceof: true
 	checkAlwaysTrueStrictComparison: true

tests/Levels/LevelsIntegrationTest.php

@@ -13,6 +13,7 @@ public function dataTopics(): array
 		return [
 			['arithmeticOperators'],
 			['onlyBooleans'],
+			['foreach'],
 		];
 	}
 

tests/Levels/data/foreach-1.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Variable $test might not be defined.",
+        "line": 11,
+        "ignorable": true
+    }
+]

tests/Levels/data/foreach.php

@@ -0,0 +1,12 @@
+<?php
+
+function () {
+	foreach ([1, 2, 3] as $val) {
+		if (rand(0, 1) === 0) {
+			break;
+		}
+		$test = 1;
+	}
+
+	echo $test;
+};