Revert "Made ConsoleApplicationResolver lazier"

This reverts commit 9251db0.

Author: ondrejmirtes

src/Symfony/ConsoleApplicationResolver.php

@@ -5,23 +5,22 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\ObjectType;
-use Symfony\Component\Console\Application;
 use function file_exists;
 use function get_class;
 use function is_readable;
 
 final class ConsoleApplicationResolver
 {
 
-	/** @var string|null */
-	private $consoleApplicationLoader;
-
-	/** @var \Symfony\Component\Console\Application|false|null */
+	/** @var \Symfony\Component\Console\Application|null */
 	private $consoleApplication;
 
 	public function __construct(?string $consoleApplicationLoader)
 	{
-		$this->consoleApplicationLoader = $consoleApplicationLoader;
+		if ($consoleApplicationLoader === null) {
+			return;
+		}
+		$this->consoleApplication = $this->loadConsoleApplication($consoleApplicationLoader);
 	}
 
 	/**
@@ -39,34 +38,12 @@ private function loadConsoleApplication(string $consoleApplicationLoader)
 		return require $consoleApplicationLoader;
 	}
 
-	public function getConsoleApplication(): ?Application
-	{
-		if ($this->consoleApplication === false) {
-			return null;
-		}
-
-		if ($this->consoleApplication !== null) {
-			return $this->consoleApplication;
-		}
-
-		if ($this->consoleApplicationLoader === null) {
-			$this->consoleApplication = false;
-
-			return null;
-		}
-
-		$this->consoleApplication = $this->loadConsoleApplication($this->consoleApplicationLoader);
-
-		return $this->consoleApplication;
-	}
-
 	/**
 	 * @return \Symfony\Component\Console\Command\Command[]
 	 */
 	public function findCommands(ClassReflection $classReflection): array
 	{
-		$consoleApplication = $this->getConsoleApplication();
-		if ($consoleApplication === null) {
+		if ($this->consoleApplication === null) {
 			return [];
 		}
 
@@ -76,7 +53,7 @@ public function findCommands(ClassReflection $classReflection): array
 		}
 
 		$commands = [];
-		foreach ($consoleApplication->all() as $name => $command) {
+		foreach ($this->consoleApplication->all() as $name => $command) {
 			if (!$classType->isSuperTypeOf(new ObjectType(get_class($command)))->yes()) {
 				continue;
 			}