Add AutowireLoader support for ContainerInterfaceUnknownServiceRule

Author: RafaelKr

src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php

@@ -8,6 +8,9 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
+use PHPStan\Symfony\AutowireLoaderServiceMapFactory;
+use PHPStan\Symfony\DefaultServiceMap;
 use PHPStan\Symfony\ServiceMap;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Symfony\Helper;
@@ -66,19 +69,55 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$serviceId = $this->serviceMap::getServiceIdFromNode($node->getArgs()[0]->value, $scope);
-		if ($serviceId !== null) {
-			$service = $this->serviceMap->getService($serviceId);
-			$serviceIdType = $scope->getType($node->getArgs()[0]->value);
-			if ($service === null && !$scope->getType(Helper::createMarkerNode($node->var, $serviceIdType, $this->printer))->equals($serviceIdType)) {
+		if ($serviceId === null) {
+			return [];
+		}
+
+		$isContainerInterfaceType = $isContainerType->yes() || $isPsrContainerType->yes();
+		if ($isContainerInterfaceType) {
+			$autowireLoaderResult = $this->getAutowireLoaderResult($node, $scope, $serviceId);
+
+			if ($autowireLoaderResult !== null) {
+				return $autowireLoaderResult;
+			}
+		}
+
+		$service = $this->serviceMap->getService($serviceId);
+		$serviceIdType = $scope->getType($node->getArgs()[0]->value);
+		if ($service === null && !$scope->getType(Helper::createMarkerNode($node->var, $serviceIdType, $this->printer))->equals($serviceIdType)) {
+			return [
+				RuleErrorBuilder::message(sprintf('Service "%s" is not registered in the container.', $serviceId))
+					->identifier('symfonyContainer.serviceNotFound')
+					->build(),
+			];
+		}
+
+		return [];
+	}
+
+	/**
+	 * @return list<PHPStan\Rules\IdentifierRuleError>|null
+	 */
+	private function getAutowireLoaderResult(Node $node, Scope $scope, string $serviceId): ?array {
+		$autowireLocatorServiceMapFactory = new AutowireLoaderServiceMapFactory($node, $scope);
+		$autowireLocatorServiceMap = $autowireLocatorServiceMapFactory->create();
+
+		// Our container has a valid AutowireLoader attribute, else we would get a FakeServiceMap.
+		if ($autowireLocatorServiceMap instanceof DefaultServiceMap) {
+			$autowireLocatorService = $autowireLocatorServiceMap->getService($serviceId);
+
+			if ($autowireLocatorService === null) {
 				return [
-					RuleErrorBuilder::message(sprintf('Service "%s" is not registered in the container.', $serviceId))
-						->identifier('symfonyContainer.serviceNotFound')
+					RuleErrorBuilder::message(sprintf('Service "%s" is not registered in the AutowireLocator.', $serviceId))
+						->identifier('symfonyContainer.undefinedService')
 						->build(),
 				];
 			}
+
+			return [];
 		}
 
-		return [];
+		return null;
 	}
 
 }