ReflectionException is never thrown

[staabm]

Bug report

I guess exception classes are mixed up because of similar name (even though different namespace)

Code snippet that reproduces the problem

https://phpstan.org/r/eae0a69f-065b-4ef4-985f-6d1f59f9ffb6

Expected output

no error

Did PHPStan help you today? Did it make you happy in any way?

No response

[staabm]

similar problem, but with another error
https://phpstan.org/r/242ff445-e23a-4d94-9278-d1e2c45bb823

expect no throws.unusedType and not catch.neverThrown errors

[ondrejmirtes]

No, PHPStan "knows" that new ReflectionClass with class-string will never throw an exception.

If you remove the generics, exception-related errors disappear: https://phpstan.org/r/da112ec4-56e9-47e3-b9a5-45168a13a502

[ondrejmirtes]

What is very relevant is that with treatPhpDocTypesAsCertain: false the dead catch could not be reported. Here's a description of how I'd like it implemented: phpstan/phpstan-src#4426 (comment)

[VincentLanglet]

@staabm Feel free if you wanna try phpstan/phpstan-src#4426 (comment), I plan to work on some other issues first.

No, PHPStan "knows" that new ReflectionClass with class-string will never throw an exception.

How is it different from

    /** @param value-of<Foo> $int */
	public function sayHello(int $int): void
	{
			Foo::from($int);
    }

then ? (cf phpstan/phpstan-src#4156 (review))

[staabm]

Feel free if you wanna try phpstan/phpstan-src#4426 (comment)

I am also loaded with tasks atm. its done when its done :). no priority for me.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.