Clean code AllInOne gateway.

Author: vuongxuongminh

src/Message/AbstractResponse.php

@@ -19,7 +19,7 @@ abstract class AbstractResponse extends BaseAbstractResponse
      * Phương thức hổ trợ tạo các thuộc tính của đối tượng từ dữ liệu gửi về từ MoMo.
      *
      * @param  string  $name
-     * @return |null
+     * @return null|string
      */
     public function __get($name)
     {

src/Message/AllInOne/AbstractIncomingRequest.php

@@ -16,4 +16,13 @@
 abstract class AbstractIncomingRequest extends BaseAbstractIncomingRequest
 {
     use Concerns\IncomingRequestParameters;
+
+    /**
+     * {@inheritdoc}
+     * @throws \Omnipay\Common\Exception\InvalidResponseException
+     */
+    public function sendData($data): IncomingResponse
+    {
+        return $this->response = new IncomingResponse($this, $data);
+    }
 }

src/Message/AllInOne/CompletePurchaseRequest.php

@@ -22,13 +22,4 @@ protected function getIncomingParametersBag(): ParameterBag
     {
         return $this->httpRequest->query;
     }
-
-    /**
-     * {@inheritdoc}
-     * @throws \Omnipay\Common\Exception\InvalidResponseException
-     */
-    public function sendData($data): IncomingResponse
-    {
-        return $this->response = new IncomingResponse($this, $data);
-    }
 }

src/Message/AllInOne/IncomingResponse.php

@@ -16,7 +16,7 @@ class IncomingResponse extends Response
     /**
      * {@inheritdoc}
      */
-    protected function getSignatureParameters(string $requestType): array
+    protected function getSignatureParameters(): array
     {
         return [
             'partnerCode', 'accessKey', 'requestId', 'amount', 'orderId', 'orderInfo', 'orderType',

src/Message/AllInOne/NotificationRequest.php

@@ -25,13 +25,4 @@ protected function getIncomingParametersBag(): ParameterBag
 
         return new ParameterBag($data);
     }
-
-    /**
-     * {@inheritdoc}
-     * @throws \Omnipay\Common\Exception\InvalidResponseException
-     */
-    public function sendData($data): IncomingResponse
-    {
-        return $this->response = new IncomingResponse($this, $data);
-    }
 }

src/Message/AllInOne/PurchaseResponse.php

@@ -15,12 +15,20 @@
  */
 class PurchaseResponse extends Response implements RedirectResponseInterface
 {
+    /**
+     * {@inheritdoc}
+     */
+    public function isSuccessful(): bool
+    {
+        return false;
+    }
+
     /**
      * {@inheritdoc}
      */
     public function isRedirect(): bool
     {
-        return $this->isSuccessful();
+        return parent::isSuccessful();
     }
 
     /**

src/Message/AllInOne/Response.php

@@ -29,7 +29,7 @@ public function __construct(RequestInterface $request, $data)
     {
         parent::__construct($request, $data);
 
-        if ($this->isSuccessful()) {
+        if ('0' === $this->getCode()) {
             $this->validateSignature();
         }
     }
@@ -41,7 +41,7 @@ public function __construct(RequestInterface $request, $data)
      */
     public function isSuccessful(): bool
     {
-        return '0' === $this->getCode() ;
+        return '0' === $this->getCode();
     }
 
     /**