Updated ip rule

Author: vuongxuongminh

src/Exceptions/IpVNException.php

@@ -24,11 +24,11 @@ class IpVNException extends ValidationException
     public static $defaultTemplates = [
         self::MODE_DEFAULT => [
             self::STANDARD => '{{name}} must be an IP address of Viet Nam',
-            self::VERSION  => '{{name}} must be an IP version {{version}}',
+            self::VERSION  => '{{name}} must be an IP address version {{version}} of Viet Nam',
         ],
         self::MODE_NEGATIVE => [
             self::STANDARD => '{{name}} must be an IP address of Viet Nam',
-            self::VERSION  => '{{name}} must be an IP version {{version}}',
+            self::VERSION  => '{{name}} must be an IP address version {{version}} of Viet Nam',
         ],
     ];
 

src/Rules/IpVN.php

@@ -11,6 +11,7 @@
 use IPLib\Address\AddressInterface as IpInterface;
 use IPLib\Address\Type as IpType;
 use IPLib\Factory as IpFactory;
+use Respect\Validation\Exceptions\ComponentException;
 use Respect\Validation\Rules\AbstractRule;
 
 /**
@@ -26,8 +27,12 @@ class IpVN extends AbstractRule
 
     public $version;
 
-    public function __construct($version = null)
+    public function __construct(?int $version = null)
     {
+        if(null !== $version && !$this->isSupportedVersion($version)) {
+            throw new ComponentException(sprintf('Only versions %d, %d are supported: %d given', self::IPV4, self::IPV6, $version));
+        }
+
         $this->version = $version;
     }
 
@@ -107,4 +112,10 @@ protected static function getIpV6Range(): array
 
         return $range;
     }
+
+    protected function isSupportedVersion(int $version): bool
+    {
+        return self::IPV4 === $version || self::IPV6 === $version;
+    }
+
 }

tests/Rules/IpVNTest.php

@@ -70,6 +70,12 @@ public function testValidV6ShouldReturnTrue($input)
         $this->assertTrue($this->validatorV6->check($input));
     }
 
+    public function testInvalidVersionShouldThrowException()
+    {
+        $this->expectException('\Respect\Validation\Exceptions\ComponentException');
+        new IpVN(100);
+    }
+
     /**
      * @dataProvider providerInvalid
      */