documentation/urls: fix broken url, adjust urls to new documentation url, make all urls and addresses constant

Author: sacry-dyn

error_handler.go

@@ -12,6 +12,8 @@ import (
 	"runtime/debug"
 )
 
+const errorsEndpoint = "https://phraseapp.com/errors"
+
 type AppCrash struct {
 	App        string `json:"app"`
 	AppVersion string `json:"app_version"`
@@ -50,7 +52,7 @@ func ReportError(name string, r interface{}, cfg *phraseapp.Config) {
 	if err != nil {
 		return
 	}
-	response, err := http.Post("https://phraseapp.com/errors", "application/json", bytes.NewBuffer(body))
+	response, err := http.Post(errorsEndpoint, "application/json", bytes.NewBuffer(body))
 
 	if err != nil {
 		return

main.go

@@ -13,14 +13,16 @@ func main() {
 	Run()
 }
 
+const phraseAppSupport = "support@phraseapp.com"
+
 func Run() {
 	var cfg *phraseapp.Config
 	defer func() {
 		if recovery := recover(); recovery != nil {
 			if PHRASEAPP_CLIENT_VERSION != "DEV" {
 				ReportError("PhraseApp Client Error", recovery, cfg)
 			}
-			printErr(fmt.Errorf("This should not have happened: %s - Contact support: support@phraseapp.com", recovery))
+			printErr(fmt.Errorf("This should not have happened: %s - Contact support: %s", recovery, phraseAppSupport))
 			os.Exit(1)
 		}
 	}()

pull.go

@@ -92,8 +92,7 @@ func (target *Target) CheckPreconditions() error {
 
 	if strings.Count(target.File, "*") > 0 {
 		return fmt.Errorf(
-			"File pattern for 'pull' cannot include any 'stars' *. Please specify direct and valid paths with file name!\n" +
-				"http://docs.phraseapp.com/developers/cli/configuration/#targets",
+			"File pattern for 'pull' cannot include any 'stars' *. Please specify direct and valid paths with file name!\n %s#targets", docsConfigUrl,
 		)
 	}
 
@@ -113,7 +112,6 @@ func (target *Target) CheckPreconditions() error {
 }
 
 func (target *Target) Pull(client *phraseapp.Client) error {
-
 	if err := target.CheckPreconditions(); err != nil {
 		return err
 	}

shared.go

@@ -20,10 +20,17 @@ type LocaleFile struct {
 
 var placeholderRegexp = regexp.MustCompile("<(locale_name|tag|locale_code)>")
 
+const docsBaseUrl = "https://phraseapp.com/docs"
+const docsConfigUrl = docsBaseUrl + "/developers/cli/configuration"
+
+func docsFormatsUrl(formatName string) string {
+	return fmt.Sprintf("%s/guides/formats/%s", docsBaseUrl, formatName)
+}
+
 func ValidPath(file, formatName, formatExtension string) error {
 	if strings.TrimSpace(file) == "" {
 		return fmt.Errorf(
-			"File patterns may not be empty!\nFor more information see http://docs.phraseapp.com/developers/cli/configuration/",
+			"File patterns may not be empty!\nFor more information see %s", docsConfigUrl,
 		)
 	}
 
@@ -39,8 +46,8 @@ func ValidPath(file, formatName, formatExtension string) error {
 
 	if formatExtension != "" && formatExtension != fileExtension {
 		return fmt.Errorf(
-			"File extension %q does not equal %q (format: %q) for file %q.\nFor more information see http://docs.phraseapp.com/guides/formats/%s",
-			fileExtension, formatExtension, formatName, file, formatName,
+			"File extension %q does not equal %q (format: %q) for file %q.\nFor more information see %s",
+			fileExtension, formatExtension, formatName, file, docsFormatsUrl(formatName),
 		)
 	}
 

version_check.go

@@ -11,6 +11,10 @@ import (
 	"github.com/phrase/phraseapp-client/Godeps/_workspace/src/github.com/dynport/dgtk/version"
 )
 
+const cliLandingPageUrl = "https://phraseapp.com/en/cli"
+
+var releaseURL = "https://github.com/phrase/phraseapp-client/releases/latest"
+
 var PHRASEAPP_VERSION_TMP_FILE = "/tmp/.phraseapp.version"
 
 func ValidateVersion() {
@@ -33,13 +37,11 @@ func validateVersionWithErr() error {
 		return err
 	}
 	if clientVersion.Less(currentVersion) {
-		return fmt.Errorf("Please consider updating the PhraseApp CLI client (%s < %s)\nSee https://phraseapp.com/en/cli", PHRASEAPP_CLIENT_VERSION, currentVersion)
+		return fmt.Errorf("Please consider updating the PhraseApp CLI client (%s < %s)\nSee %s", PHRASEAPP_CLIENT_VERSION, currentVersion, cliLandingPageUrl)
 	}
 	return nil
 }
 
-var releaseURL = "https://github.com/phrase/phraseapp-client/releases/latest"
-
 func getLatestReleaseVersion() (string, error) {
 	req, err := http.NewRequest("HEAD", releaseURL, nil)
 	if err != nil {

wizard.go

@@ -19,7 +19,6 @@ import (
 	"github.com/phrase/phraseapp-client/Godeps/_workspace/src/github.com/phrase/phraseapp-go/phraseapp"
 )
 
-const docsURL = "http://docs.phraseapp.com/developers/cli/configuration"
 const parrot = `
                                ppe############eep
                          p############################pp
@@ -265,7 +264,7 @@ func pushConfig(data *WizardData) error {
 	}
 
 	fmt.Println("Enter the path to your local language files, you want to upload to PhraseApp.")
-	fmt.Println("For documentation see http://docs.phraseapp.com/developers/cli/configuration/#sources")
+	fmt.Printf("For documentation see %s#push", docsConfigUrl)
 
 	var pushPath string
 	for {
@@ -295,7 +294,7 @@ func pullConfig(data *WizardData) error {
 	}
 
 	fmt.Println("Enter the path to where you want to store downloaded language files from PhraseApp.")
-	fmt.Println("For documentation see http://docs.phraseapp.com/developers/cli/configuration/#targets")
+	fmt.Printf("For documentation see %s#pull", docsConfigUrl)
 
 	var pullPath string
 	for {
@@ -382,7 +381,7 @@ func writeConfig(data *WizardData, filename string) error {
 	fmt.Println("")
 	fmt.Println(string(bytes))
 
-	printSuccess("You can make changes to this file, see this documentation for more advanced options: " + docsURL)
+	printSuccess("You can make changes to this file, see this documentation for more advanced options: " + docsConfigUrl)
 	printSuccess("Now start using phraseapp push & pull for your workflow:")
 	fmt.Println("")
 	fmt.Println("$ phraseapp push")