fix(cli): CLI do not exit with 0 on pull when branch does not exist (#768)

BlumMichael · web-flow · commit e7d8c435dafe · 2025-01-15T11:06:09.000+01:00
diff --git a/clients/cli/cmd/internal/pull.go b/clients/cli/cmd/internal/pull.go
@@ -71,7 +71,7 @@ func (cmd *PullCommand) Run(config *phrase.Config) error {
 		val, ok := localesCache[LocalesCacheKey{target.ProjectID, target.GetBranch()}]
 		if !ok || len(val) == 0 {
 			if cmd.Branch != "" {
-				continue
+				return fmt.Errorf("Branch '%s' does not exist in project '%s'", cmd.Branch, target.ProjectID)
 			}
 			return fmt.Errorf("Could not find any locales for project %q", target.ProjectID)
 		}
diff --git a/clients/cli/go.mod b/clients/cli/go.mod
@@ -11,7 +11,7 @@ require (
 	github.com/daviddengcn/go-colortext v1.0.0
 	github.com/jpillora/backoff v1.0.0
 	github.com/mitchellh/mapstructure v1.5.0
-	github.com/phrase/phrase-go/v4 v4.0.5 // x-release-please-version
+	github.com/phrase/phrase-go/v4 v4.1.0 // x-release-please-version
 	github.com/spf13/cobra v1.8.1
 	github.com/spf13/viper v1.19.0
 	gopkg.in/yaml.v2 v2.4.0

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ func (cmd PullCommand) Run(config phrase.Config) error {`
`71`	`71`	`val, ok := localesCache[LocalesCacheKey{target.ProjectID, target.GetBranch()}]`
`72`	`72`	`if !ok \|\| len(val) == 0 {`
`73`	`73`	`if cmd.Branch != "" {`
`74`		`- continue`
	`74`	`+ return fmt.Errorf("Branch '%s' does not exist in project '%s'", cmd.Branch, target.ProjectID)`
`75`	`75`	`}`
`76`	`76`	`return fmt.Errorf("Could not find any locales for project %q", target.ProjectID)`
`77`	`77`	`}`