Skip to content

Commit 4dda140

Browse files
authored
Fix test failure to to phylum.io redirect (#1575)
This fixes an issue caused by phylum.io redirecting to veracode.com, which caused our sandbox to complain that network access permissions to veracode.com were missing. Some other tests also used `phylum.io` as dummy URIs. While these were never hit, they've been replaced for consistency and future-proofing. There are still several instances referencing `api.phylum.io` or `docs.phylum.io`, which have been left unchanged since no Veracode alternative exists yet.
1 parent 1b33c06 commit 4dda140

File tree

10 files changed

+14
-14
lines changed

10 files changed

+14
-14
lines changed

cli/src/permissions.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ impl From<&Permissions> for PermissionsOptions {
264264

265265
let mut allow_net = value.net.clone();
266266

267-
// Add net exceptions to phylum.io's domains by default.
267+
// Add net exceptions to Veracode's domains by default.
268268
allow_net.allow_resource("api.staging.phylum.io".into());
269269
allow_net.allow_resource("api.phylum.io".into());
270270

cli/tests/extensions/permissions.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ fn incorrect_net_permission_unsuccessful_run() {
7070
test_cli
7171
.run(["incorrect-net-perms"])
7272
.failure()
73-
.stderr("❗ Error: Requires net access to \"phylum.io:443\"\n");
73+
.stderr("❗ Error: Requires net access to \"veracode.com:443\"\n");
7474
}
7575

7676
#[test]

cli/tests/fixtures/extensions/permissions/correct-net-perms/PhylumExt.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ description = "An extension with correctly specified permissions"
33
entry_point = "main.ts"
44

55
[permissions]
6-
net = ["www.phylum.io"]
6+
net = ["www.veracode.com"]
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
let response = await fetch('https://www.phylum.io')
1+
let response = await fetch('https://www.veracode.com')
22
let release = await response.text()
33

44
console.log(release)

cli/tests/fixtures/extensions/permissions/incorrect-net-perms/PhylumExt.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ description = "An extension with incorrectly specified permissions"
33
entry_point = "main.ts"
44

55
[permissions]
6-
net = ["phylum.dev"]
6+
net = ["veracode.dev"]
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
let response = await fetch('https://phylum.io')
1+
let response = await fetch('https://veracode.com')
22
let release = await response.json()
33

44
console.log(release)

lockfile/src/cargo.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ mod tests {
185185
Package {
186186
name: "zstd-sys".into(),
187187
version: PackageVersion::ThirdParty(ThirdPartyVersion {
188-
registry: "https://phylum.io/foreign-registry-example".into(),
188+
registry: "https://invalid.veracode.com/foreign-registry-example".into(),
189189
version: "1.6.3+zstd.1.5.2".into(),
190190
}),
191191
package_type: PackageType::Cargo,

lockfile/src/python.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,15 +304,15 @@ mod tests {
304304
Package {
305305
name: "other-registry-a".into(),
306306
version: PackageVersion::ThirdParty(ThirdPartyVersion {
307-
registry: "https://mirror1.phylum.io/simple/".into(),
307+
registry: "https://mirror1.veracode.com/simple/".into(),
308308
version: "3.2.1".into(),
309309
}),
310310
package_type: PackageType::PyPi,
311311
},
312312
Package {
313313
name: "other-registry".into(),
314314
version: PackageVersion::ThirdParty(ThirdPartyVersion {
315-
registry: "https://mirror2.phylum.io/simple/".into(),
315+
registry: "https://mirror2.veracode.com/simple/".into(),
316316
version: "1.2.3".into(),
317317
}),
318318
package_type: PackageType::PyPi,

tests/fixtures/Cargo_v3.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5577,7 +5577,7 @@ dependencies = [
55775577
[[package]]
55785578
name = "zstd-sys"
55795579
version = "1.6.3+zstd.1.5.2"
5580-
source = "registry+https://phylum.io/foreign-registry-example"
5580+
source = "registry+https://invalid.veracode.com/foreign-registry-example"
55815581
checksum = "fc49afa5c8d634e75761feda8c592051e7eeb4683ba827211eb0d731d3402ea8"
55825582
dependencies = [
55835583
"cc",

tests/fixtures/requirements-locked.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ tomli @ https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a25
3636

3737
-e /tmp/editable ; python_version >= "3.7" and python_version < "3.12"
3838

39-
--index-url https://unused.phylum.io/simple/
40-
--index-url=https://mirror1.phylum.io/simple/
39+
--index-url https://unused.veracode.com/simple/
40+
--index-url=https://mirror1.veracode.com/simple/
4141
other-registry-a==3.2.1
42-
-ihttps://mirror2.phylum.io/simple/
43-
--extra-index-url=https://mirror3.phylum.io/simple/
42+
-ihttps://mirror2.veracode.com/simple/
43+
--extra-index-url=https://mirror3.veracode.com/simple/
4444
other-registry==1.2.3

0 commit comments

Comments
 (0)