Skip to content

Commit 1d68799

Browse files
committed
Update SUCCESS comment language in GitHub App doc
This change is made to keep in sync with the GitHub App update that removed the `SUCCESS` comments for PRs.
1 parent d837ee9 commit 1d68799

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed
-32.3 KB
Binary file not shown.

docs/integrations/github_app.md

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ If an issue causes the job to fail the [defined policy], the GitHub check for th
6060

6161
For Pull Requests, the dependencies of the PR branch are compared against the dependencies of the main branch. If the dependencies have changed, the dependencies of the PR branch are submitted for analysis. If the dependencies have not changed, the GitHub check will pass without creating an analysis in Phylum.
6262

63-
If the Phylum analysis fails the [defined policy] because of an issue related to a changed dependency, the GitHub check will fail and a comment will be written to the PR. If one or more dependencies are still processing (no results available), then the comment will make that clear and the CI job will only fail if dependencies that have **completed analysis results** do not meet the active policy.
63+
If the Phylum analysis fails the [defined policy] because of an issue related to a changed dependency, the GitHub check will fail and a comment will be written to the PR. If one or more dependencies are still processing (no results available), then the comment will make that clear and the CI job will only fail if dependencies that have **completed analysis results** do not meet the active policy. There will be no comment when the results of the analysis are successful.
6464

6565
[defined policy]: ../knowledge_base/policy.md
6666

@@ -86,12 +86,6 @@ Phylum OSS Supply Chain Risk Analysis - INCOMPLETE
8686

8787
---
8888

89-
Phylum OSS Supply Chain Risk Analysis - SUCCESS
90-
91-
![GitHub app PR comment - success](../../assets/gh_app_pr_comment_success.png)
92-
93-
---
94-
9589
### Groups
9690

9791
> **NOTE:** Only [Phylum PRO accounts](https://www.phylum.io/pricing) support groups.

0 commit comments

Comments
 (0)