Copilot suggestions

Author: Grufoony

profiling/CMakeLists.txt

@@ -29,7 +29,6 @@ if(NOT rapidcsv_POPULATED)
 endif()
 
 file(GLOB SOURCES "../src/dsf/base/*.cpp" "../src/dsf/mobility/*.cpp" "../src/dsf/utility/*.cpp" "../src/dsf/geometry/*.cpp")
-list(FILTER SOURCES EXCLUDE REGEX ".*binding.*\\.cpp$")
 
 # Define the executable
 add_executable(prof.out main.cpp ${SOURCES})

src/dsf/geometry/Point.cpp

@@ -5,7 +5,6 @@
 
 namespace dsf {
   namespace geometry {
-    Point::Point(double x, double y) : m_x(x), m_y(y) {}
     Point::Point(const std::string& strPoint, const std::string& format) {
       if (format == "WKT") {
         auto start = strPoint.find('(');

src/dsf/geometry/Point.hpp

@@ -19,7 +19,7 @@ namespace dsf {
       /// @brief Construct a Point with given x and y coordinates.
       /// @param x The x coordinate
       /// @param y The y coordinate
-      Point(double x, double y);
+      Point(double x, double y) : m_x(x), m_y(y) {}
       /// @brief Construct a Point from a string representation.
       /// @param strPoint The string representation of the point.
       /// @param format The format of the string representation. Default is "WKT".

src/dsf/mobility/Intersection.cpp

@@ -1,7 +1,5 @@
 #include "Intersection.hpp"
 
-#include <algorithm>
-#include <cmath>
 #include <stdexcept>
 
 namespace dsf::mobility {

src/dsf/mobility/Intersection.hpp

@@ -103,10 +103,11 @@ namespace dsf::mobility {
     /// @details This function returns the number of agents that have passed through the node
     ///          since the last time this function was called. It also resets the counter.
     Size agentCounter();
-
+    /// @brief Returns the number of agents currently in the node
+    /// @return Size The number of agents currently in the node
     Size nAgents() const { return m_agents.size(); }
 
-    bool isIntersection() const noexcept final { return true; }
+    constexpr bool isIntersection() const noexcept final { return true; }
   };
 }  // namespace dsf::mobility
 

src/dsf/mobility/Roundabout.hpp

@@ -55,6 +55,6 @@ namespace dsf::mobility {
     bool isFull() const override { return m_agents.size() == this->capacity(); }
     /// @brief Returns true if the node is a roundabout
     /// @return bool True if the node is a roundabout
-    bool isRoundabout() const noexcept override { return true; }
+    constexpr bool isRoundabout() const noexcept final { return true; }
   };
 }  // namespace dsf::mobility

src/dsf/mobility/Station.cpp

@@ -33,6 +33,4 @@ namespace dsf::mobility {
   }
 
   bool Station::isFull() const { return m_trains.size() >= this->capacity(); }
-
-  bool Station::isStation() const noexcept { return true; }
 }  // namespace dsf::mobility

src/dsf/mobility/Station.hpp

@@ -51,6 +51,6 @@ namespace dsf::mobility {
     bool isFull() const;
     /// @brief Check if the node is a station
     /// @return True
-    bool isStation() const noexcept;
+    constexpr bool isStation() const noexcept final { return true; }
   };
 }  // namespace dsf::mobility

src/dsf/mobility/TrafficLight.hpp

@@ -138,7 +138,7 @@ namespace dsf::mobility {
     /// @brief Resets all traffic light cycles
     /// @details For more info, see @ref TrafficLightCycle::reset()
     void resetCycles();
-    inline bool isTrafficLight() const noexcept { return true; }
+    constexpr bool isTrafficLight() const noexcept { return true; }
   };
 }  // namespace dsf::mobility
 

test/Test_node.cpp

@@ -3,7 +3,7 @@
 #include "../src/dsf/base/Node.hpp"
 #include "../src/dsf/mobility/Intersection.hpp"
 #include "../src/dsf/mobility/TrafficLight.hpp"
-#include "../src/dsf/mobility/Roundabout.hpp"
+// #include "../src/dsf/mobility/Roundabout.hpp"
 #include "../src/dsf/mobility/Station.hpp"
 #include "../src/dsf/utility/Typedef.hpp"