Fix some warnings

Author: Grufoony

benchmark/Street/BenchStreet.cpp

@@ -13,7 +13,7 @@ using SparseMatrix = dsm::SparseMatrix<bool>;
 using Bench = sb::Bench<long long int>;
 
 int main() {
-  Street street(0, 1000, 10., std::make_pair(0, 1));
+  Street street(0, std::make_pair(0, 1), 5000.);
   Agent agent(0, 0, 0);
   Bench b(1000);
 

src/dsm/headers/Dynamics.hpp

@@ -221,7 +221,7 @@ namespace dsm {
     const std::map<Id, std::unique_ptr<agent_t>>& agents() const { return m_agents; }
     /// @brief Get the number of agents currently in the simulation
     /// @return Size The number of agents
-    const Size nAgents() const { return m_agents.size(); }
+    Size nAgents() const { return m_agents.size(); }
     /// @brief Get the time
     /// @return Time The time
     Time time() const { return m_time; }

src/dsm/headers/Node.hpp

@@ -30,7 +30,7 @@ namespace dsm {
     std::optional<std::pair<double, double>> m_coords;
     std::string m_name;
     Size m_capacity;
-    Size m_transportCapacity;
+    int m_transportCapacity;
 
   public:
     /// @brief Construct a new Node object with capacity 1
@@ -79,7 +79,13 @@ namespace dsm {
     virtual void setCapacity(Size capacity) { m_capacity = capacity; }
     /// @brief Set the node's transport capacity
     /// @param capacity The node's transport capacity
-    virtual void setTransportCapacity(Size capacity) { m_transportCapacity = capacity; }
+    virtual void setTransportCapacity(int capacity) {
+      if (capacity < 1) {
+        throw std::invalid_argument(buildLog(std::format(
+            "The transport capacity of a node ({}) must be greater than 0.", capacity)));
+      }
+      m_transportCapacity = capacity;
+    }
     /// @brief Get the node's id
     /// @return Id The node's id
     Id id() const { return m_id; }
@@ -94,7 +100,7 @@ namespace dsm {
     Size capacity() const { return m_capacity; }
     /// @brief Get the node's transport capacity
     /// @return Size The node's transport capacity
-    Size transportCapacity() const { return m_transportCapacity; }
+    int transportCapacity() const { return m_transportCapacity; }
 
     virtual double density() const = 0;
     virtual bool isFull() const = 0;

src/dsm/headers/RoadDynamics.hpp

@@ -420,7 +420,6 @@ namespace dsm {
               if (std::abs(deltaAngle) < std::numbers::pi) {
                 // Lanes are counted as 0 is the far right lane
                 if (std::abs(deltaAngle) < std::numbers::pi / 4) {
-                  auto const dstNodeId = pNextStreet->nodePair().first;
                   std::vector<double> weights;
                   for (auto const& queue : street->exitQueues()) {
                     weights.push_back(1. / (queue.size() + 1));

src/dsm/headers/Street.cpp

@@ -8,9 +8,9 @@ namespace dsm {
       : Edge(id, street.nodePair(), street.capacity(), street.transportCapacity()),
         m_length{street.length()},
         m_maxSpeed{street.maxSpeed()},
-        m_angle{street.angle()},
         m_nLanes{street.nLanes()},
-        m_name{street.name()} {
+        m_name{street.name()},
+        m_angle{street.angle()} {
     for (auto i{0}; i < street.nLanes(); ++i) {
       m_exitQueues.push_back(dsm::queue<Size>());
     }
@@ -135,8 +135,8 @@ namespace dsm {
     return id;
   }
 
-  Size Street::nAgents() const {
-    Size nAgents{static_cast<Size>(m_waitingAgents.size())};
+  int Street::nAgents() const {
+    auto nAgents{static_cast<int>(m_waitingAgents.size())};
     for (const auto& queue : m_exitQueues) {
       nAgents += queue.size();
     }

src/dsm/headers/Street.hpp

@@ -39,9 +39,9 @@ namespace dsm {
     std::set<Id> m_waitingAgents;
     double m_length;
     double m_maxSpeed;
-    double m_angle;
-    std::string m_name;
     int m_nLanes;
+    std::string m_name;
+    double m_angle;
     static double m_meanVehicleLength;
 
   public:
@@ -105,7 +105,7 @@ namespace dsm {
     const std::vector<dsm::queue<Size>>& exitQueues() const { return m_exitQueues; }
     /// @brief  Get the number of agents on the street
     /// @return Size, The number of agents on the street
-    Size nAgents() const;
+    int nAgents() const;
     /// @brief Get the street's density in \f$m^{-1}\f$ or in \f$a.u.\f$, if normalized
     /// @param normalized If true, the street's density is normalized by the street's capacity
     /// @return double, The street's density

src/dsm/headers/TrafficLight.cpp

@@ -200,8 +200,8 @@ namespace dsm {
 
   bool TrafficLight::isFavouringDirection(bool const priority) const {
     for (auto const& [streetId, cycles] : m_cycles) {
-      if ((priority && m_streetPriorities.contains(streetId) ||
-           (!priority && !m_streetPriorities.contains(streetId)))) {
+      if ((priority && m_streetPriorities.contains(streetId)) ||
+          (!priority && !m_streetPriorities.contains(streetId))) {
         for (auto const& cycle : cycles) {
           if (!cycle.isGreenTimeIncreased()) {
             return false;