Bump vesrion adn copilot fixes

Author: Grufoony

src/dsf/bindings.cpp

@@ -264,10 +264,12 @@ PYBIND11_MODULE(dsf_cpp, m) {
           "Args:\n"
           "    sourceId (int): The id of the source node\n"
           "    targetId (int): The id of the target node\n"
-          "    weightFunction (PathWeight): The weight function to use (LENGTH, TRAVELTIME, or WEIGHT)\n"
+          "    weightFunction (PathWeight): The weight function to use (LENGTH, "
+          "TRAVELTIME, or WEIGHT)\n"
           "    threshold (float): A threshold value to consider alternative paths\n\n"
           "Returns:\n"
-          "    PathCollection: A map where each key is a node id and the value is a vector of next hop node ids toward the target");
+          "    PathCollection: A map where each key is a node id and the value is a "
+          "vector of next hop node ids toward the target");
 
   pybind11::class_<dsf::mobility::PathCollection>(mobility, "PathCollection")
       .def(pybind11::init<>(), "Create an empty PathCollection")
@@ -284,9 +286,9 @@ PYBIND11_MODULE(dsf_cpp, m) {
           "Get the next hops for a given node id")
       .def(
           "__setitem__",
-          [](dsf::mobility::PathCollection& self, dsf::Id key, std::vector<dsf::Id> value) {
-            self[key] = value;
-          },
+          [](dsf::mobility::PathCollection& self,
+             dsf::Id key,
+             std::vector<dsf::Id> value) { self[key] = value; },
           pybind11::arg("key"),
           pybind11::arg("value"),
           "Set the next hops for a given node id")
@@ -322,12 +324,11 @@ PYBIND11_MODULE(dsf_cpp, m) {
             return items;
           },
           "Get all items (node id, next hops) in the collection")
-      .def(
-          "explode",
-          &dsf::mobility::PathCollection::explode,
-          pybind11::arg("sourceId"),
-          pybind11::arg("targetId"),
-          dsf::g_docstrings.at("dsf::mobility::PathCollection::explode").c_str());
+      .def("explode",
+           &dsf::mobility::PathCollection::explode,
+           pybind11::arg("sourceId"),
+           pybind11::arg("targetId"),
+           dsf::g_docstrings.at("dsf::mobility::PathCollection::explode").c_str());
 
   pybind11::class_<dsf::mobility::Itinerary>(mobility, "Itinerary")
       .def(pybind11::init<dsf::Id, dsf::Id>(),

src/dsf/dsf.hpp

@@ -6,7 +6,7 @@
 
 static constexpr uint8_t DSF_VERSION_MAJOR = 4;
 static constexpr uint8_t DSF_VERSION_MINOR = 4;
-static constexpr uint8_t DSF_VERSION_PATCH = 0;
+static constexpr uint8_t DSF_VERSION_PATCH = 1;
 
 static auto const DSF_VERSION =
     std::format("{}.{}.{}", DSF_VERSION_MAJOR, DSF_VERSION_MINOR, DSF_VERSION_PATCH);

src/dsf/mobility/Itinerary.hpp

@@ -44,7 +44,7 @@ namespace dsf::mobility {
 
     /// @brief Set the itinerary's path
     /// @param pathCollection A dsf::mobility::PathCollection representing all equivalent paths to the destination
-    void setPath(PathCollection path);
+    void setPath(PathCollection pathCollection);
 
     /// @brief Get the itinerary's id
     /// @return Id, The itinerary's id

src/dsf/mobility/RoadNetwork.hpp

@@ -202,7 +202,6 @@ namespace dsf::mobility {
     /// @param threshold A threshold value to consider alternative paths
     /// @return A map where each key is a node id and the value is a vector of next hop node ids toward the target
     /// @throws std::out_of_range if the target node does not exist
-    /// @throws std::invalid_argument if the dynamics function is not callable with a const reference
     template <typename DynamicsFunc>
       requires(std::is_invocable_r_v<double, DynamicsFunc, std::unique_ptr<Street> const&>)
     PathCollection allPathsTo(Id const targetId,
@@ -314,7 +313,6 @@ namespace dsf::mobility {
   PathCollection RoadNetwork::allPathsTo(Id const targetId,
                                          DynamicsFunc f,
                                          double const threshold) const {
-    // Check if source node exists
     auto const& nodes = this->nodes();
 
     // Distance from each node to the source (going backward)

test/mobility/Test_graph.cpp

@@ -662,8 +662,7 @@ TEST_CASE("ShortestPath") {
     CHECK_FALSE(pathMap.contains(3));
   }
 
-  SUBCASE("Complex Network with Coordinates - A* Heuristic") {
-    // Test with coordinates to verify A* heuristic is being used
+  SUBCASE("Complex Network with Coordinates") {
     RoadNetwork graph{};
     graph.addNode(0, dsf::geometry::Point(0.0, 0.0));
     graph.addNode(1, dsf::geometry::Point(10.0, 0.0));
@@ -841,10 +840,8 @@ TEST_CASE("ShortestPath") {
     // Test explode function
     auto allPaths = pathMap.explode(0, 5);
 
-    // There should be 6 shortest paths of length 4 (4 hops):
-    // 0->1->2->5, 0->1->4->5, 0->3->4->5, 0->3->4->2->5 (no, this is longer)
-    // Actually: 0->1->2->5, 0->1->4->5, 0->3->4->5, 0->1->4->2->5 (no reverse edge)
-    // Let me recalculate: all shortest paths have length 40 (4 edges)
+    // All shortest paths from 0 to 5 have length 40 (4 edges).
+    // There are 3 such shortest paths: 0->1->2->5, 0->1->4->5, and 0->3->4->5.
     CHECK_GT(allPaths.size(), 0);
 
     // Verify all paths start at 0 and end at 5