Skip to content

Conversation

@Grufoony
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (95e4b21) to head (a122871).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dsm/sources/RoadNetwork.cpp 71.42% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   90.77%   90.62%   -0.16%     
==========================================
  Files          36       36              
  Lines        5085     5108      +23     
  Branches      463      467       +4     
==========================================
+ Hits         4616     4629      +13     
- Misses        469      479      +10     
Flag Coverage Δ
unittests 90.62% <73.33%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

std::istringstream iss{line};
std::string sourceId, targetId, length, lanes, highway, maxspeed, name, geometry;
// u;v;length;highway;maxspeed;name;geometry
std::string sourceId, targetId, length, lanes, highway, maxspeed, name, geometry,

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.3 rule Note

MISRA 12.3 rule
for (auto const& [streetId, pStreet] : m_edges) {
file << streetId << ';' << pStreet->source() << ';' << pStreet->target() << ';'
<< pStreet->name() << ';';
if (pStreet->isSpire()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 14.4 rule Note

MISRA 14.4 rule
} else {
file << "Nan;Nan";
}
if (pNode->isTrafficLight()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 14.4 rule Note

MISRA 14.4 rule
}
if (pNode->isTrafficLight()) {
file << ";traffic_light";
} else if (pNode->isRoundabout()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 14.4 rule Note

MISRA 14.4 rule
}
std::istringstream iss{line};
std::string nodeId, lat, lon;
std::string nodeId, lat, lon, type;

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.3 rule Note

MISRA 12.3 rule
auto const& it{m_nodes.find(std::stoul(nodeId))};
if (it != m_nodes.cend()) {
it->second->setCoords(std::make_pair(dLat, dLon));
if (type == "traffic_light" && !it->second->isTrafficLight()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.1 rule Note

MISRA 12.1 rule
if (it != m_nodes.cend()) {
it->second->setCoords(std::make_pair(dLat, dLon));
if (type == "traffic_light" && !it->second->isTrafficLight()) {
makeTrafficLight(it->first, 60);

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 17.7 rule Note

MISRA 17.7 rule
it->second->setCoords(std::make_pair(dLat, dLon));
if (type == "traffic_light" && !it->second->isTrafficLight()) {
makeTrafficLight(it->first, 60);
} else if (type == "roundabout" && !it->second->isRoundabout()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.1 rule Note

MISRA 12.1 rule
if (type == "traffic_light" && !it->second->isTrafficLight()) {
makeTrafficLight(it->first, 60);
} else if (type == "roundabout" && !it->second->isRoundabout()) {
makeRoundabout(it->first);

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 17.7 rule Note

MISRA 17.7 rule
makeTrafficLight(it->first, 60);
} else if (type == "roundabout" && !it->second->isRoundabout()) {
makeRoundabout(it->first);
}

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 15.7 rule Note

MISRA 15.7 rule
@Grufoony Grufoony merged commit ddd13d9 into main Feb 20, 2025
29 of 31 checks passed
@Grufoony Grufoony deleted the OSMcoils branch February 20, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants