-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add instructions for excluding Pi-hole from Watchtower updates #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Added instructions to exclude Pi-hole container from Watchtower's auto-update system. Signed-off-by: Alex Ferrarini <[email protected]>
yubiuser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd prefer to just link to the respective watchtower documentation on how to exclude a specific service from it. Our Readme is already quite long. I think linking to the right place of their documentation is already enough hand-holding.
|
I agree. A link to the Full Exclude option is enough. |
|
Yeah, maybe just a link is enough, the watchtower guide for Full Exclusion is pretty straightforward, there's no need for a further explaination in the Pi-hole documentation. |
Removed full explaination, reduced to a single link. Signed-off-by: Alex Ferrarini <[email protected]>
| - If you care about your data (logs/customizations), make sure you have it volume-mapped or it will be deleted in this step. | ||
| - Recreate the container using the new image. | ||
| If you wish to exclude the Pi-hole container from Watchtower's auto-update system take a look at [Full Exclude](https://containrrr.dev/watchtower/container-selection/#full_exclude) in Watchtower's docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you wish to exclude the Pi-hole container from Watchtower's auto-update system take a look at [Full Exclude](https://containrrr.dev/watchtower/container-selection/#full_exclude) in Watchtower's docs. | |
| To exclude the Pi-hole container from Watchtower's auto-update system take a look at [Full Exclude](https://containrrr.dev/watchtower/container-selection/#full_exclude) in Watchtower's docs. |
Just this tweak from me please - keeps the tone more in line with the overall message we are trying to get across.
And just to keep it tidy, please squash the commits down to one
thanks!
Added instructions to exclude Pi-hole container from Watchtower's auto-update system.
Description
Modified the README file in order to add the instructions to fully exclude the Pi-hole container from Watchtower.
The instructions can be find in Watchtower's official documentation Full exclude section
Motivation and Context
This change avoids a new Pi-hole user to go back on Watchtower's documentation to find how to exclude some container from the auto-update system.
The simple pice of setting that needs to be added on the Docker-compose is now available directly in the Pi-hole README
How Has This Been Tested?
Types of changes
Checklist: