Automigration creation of same table but different schema

[j0hn-mc-clane]

Hello

I found a small bug inside of the DiffableTable logic.
The equals check in DiffableTable should also check the schema for true equality.

Proposal:

def better_eq(self, value) -> bool:
    if not isinstance(value, DiffableTable):
        return False
    return (
        (self.schema == value.schema)
        and (self.class_name == value.class_name)
        and (self.tablename == value.tablename)
    )


DiffableTable.__eq__ = better_eq

Thanks for taking this up.

Cheers

[j0hn-mc-clane]

Remark: migration_manager.sort_table_classes should also be changed I assume, I patched it with a simple list of table_classes because I have no FKs between my models

[dantownsend]

Ah yes, good catch.

[juneja-varun]

I'll take a shot at this.

[juneja-varun]

Opened #1427 with a fix for this.