Skip to content

Commit 1d29e45

Browse files
added issue_template.md
1 parent 5c2b5d8 commit 1d29e45

File tree

5 files changed

+52
-16
lines changed

5 files changed

+52
-16
lines changed

.github/issue_template.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
### Expected Behavior
2+
3+
4+
### Actual Behavior
5+
6+
7+
### Sublime Text console logs
8+
<!-- to see the logs, go to View > Show Console, then copy and paste here eventual errors -->
9+
10+
### Screenshots
11+
<!-- post here screenshots/gifs that may help to understand the problem -->
12+
13+
### Steps to Reproduce the Problem
14+
15+
1.
16+
1.
17+
1.
18+
19+
### Specifications
20+
21+
- Sublime Text 3 build:
22+
- OS:
23+
- JavaScript Enhancements version:

Main.sublime-menu

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,11 @@
136136
"default": "{}"
137137
},
138138
"caption": "Key Bindings"
139+
},
140+
{ "caption": "-" },
141+
{
142+
"caption": "Version",
143+
"command": "show_javascript_enhancements_version"
139144
}
140145
]
141146
}

_generated_2018_01_09_at_00_20_38.py renamed to _generated_2018_01_09_at_16_37_39.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
from shutil import copyfile
44
from threading import Timer
55

6+
PLUGIN_VERSION = "0.11.1"
7+
68
PACKAGE_PATH = os.path.abspath(os.path.dirname(__file__))
79
PACKAGE_NAME = os.path.basename(PACKAGE_PATH)
810
SUBLIME_PACKAGES_PATH = os.path.dirname(PACKAGE_PATH)
@@ -1268,6 +1270,11 @@ def overwrite_default_javascript_snippet():
12681270
if file_name.endswith(".sublime-snippet") and os.path.isfile(os.path.join(PACKAGE_PATH, "JavaScript-overwrite-default-snippet", file_name)) :
12691271
shutil.copy(os.path.join(PACKAGE_PATH, "JavaScript-overwrite-default-snippet", file_name), os.path.join(SUBLIME_PACKAGES_PATH, "JavaScript", "Snippets", file_name))
12701272

1273+
class show_javascript_enhancements_versionCommand(sublime_plugin.WindowCommand):
1274+
def run(self):
1275+
if sublime.ok_cancel_dialog("JavaScript Enhancements plugin version: "+PLUGIN_VERSION, "Copy"):
1276+
sublime.set_clipboard(PLUGIN_VERSION)
1277+
12711278
class startPlugin():
12721279
def init(self):
12731280

@@ -4336,10 +4343,10 @@ def on_activated_async(self) :
43364343
view = self.view
43374344

43384345
selections = view.sel()
4339-
4346+
43404347
if len(selections) == 0:
43414348
return
4342-
4349+
43434350
sel = selections[0]
43444351
if not view.match_selector(
43454352
sel.begin(),
@@ -5359,10 +5366,7 @@ def start():
53595366

53605367
global mainPlugin
53615368

5362-
# if sublime.platform() == 'windows':
5363-
# print(sublime.platform())
5364-
# sublime.error_message("Windows is not supported by this plugin for now.")
5365-
# return
5369+
print("JavaScript Enhancements plugin version: "+PLUGIN_VERSION)
53665370

53675371
if platform.architecture()[0] != "64bit":
53685372
print(platform.architecture())
@@ -5387,7 +5391,7 @@ def start():
53875391

53885392
node = NodeJS(check_local=True)
53895393
try:
5390-
print(node.getCurrentNodeJSVersion())
5394+
print("node.js version: " + str(node.getCurrentNodeJSVersion()))
53915395
except Exception as err:
53925396
print(err)
53935397
response = sublime.yes_no_cancel_dialog("Error during installation: \"node.js\" seems not installed on your system. Node.js and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please then change the path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")
@@ -5399,7 +5403,7 @@ def start():
53995403

54005404
npm = NPM(check_local=True)
54015405
try:
5402-
print(npm.getCurrentNPMVersion())
5406+
print("npm version: " + str(npm.getCurrentNPMVersion()))
54035407
except Exception as err:
54045408
print(err)
54055409
response = sublime.yes_no_cancel_dialog("Error during installation: \"npm\" seems not installed on your system. Node.js and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please change their custom path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")

helper/javascript_completions/show_flow_errors_view_event_listener.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ def on_activated_async(self) :
1313
view = self.view
1414

1515
selections = view.sel()
16-
16+
1717
if len(selections) == 0:
1818
return
19-
19+
2020
sel = selections[0]
2121
if not view.match_selector(
2222
sel.begin(),

make/_init.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
from shutil import copyfile
44
from threading import Timer
55

6+
PLUGIN_VERSION = "0.11.1"
7+
68
PACKAGE_PATH = os.path.abspath(os.path.dirname(__file__))
79
PACKAGE_NAME = os.path.basename(PACKAGE_PATH)
810
SUBLIME_PACKAGES_PATH = os.path.dirname(PACKAGE_PATH)
@@ -77,6 +79,11 @@ def overwrite_default_javascript_snippet():
7779
if file_name.endswith(".sublime-snippet") and os.path.isfile(os.path.join(PACKAGE_PATH, "JavaScript-overwrite-default-snippet", file_name)) :
7880
shutil.copy(os.path.join(PACKAGE_PATH, "JavaScript-overwrite-default-snippet", file_name), os.path.join(SUBLIME_PACKAGES_PATH, "JavaScript", "Snippets", file_name))
7981

82+
class show_javascript_enhancements_versionCommand(sublime_plugin.WindowCommand):
83+
def run(self):
84+
if sublime.ok_cancel_dialog("JavaScript Enhancements plugin version: "+PLUGIN_VERSION, "Copy"):
85+
sublime.set_clipboard(PLUGIN_VERSION)
86+
8087
class startPlugin():
8188
def init(self):
8289

@@ -117,10 +124,7 @@ def start():
117124

118125
global mainPlugin
119126

120-
# if sublime.platform() == 'windows':
121-
# print(sublime.platform())
122-
# sublime.error_message("Windows is not supported by this plugin for now.")
123-
# return
127+
print("JavaScript Enhancements plugin version: "+PLUGIN_VERSION)
124128

125129
if platform.architecture()[0] != "64bit":
126130
print(platform.architecture())
@@ -145,7 +149,7 @@ def start():
145149

146150
node = NodeJS(check_local=True)
147151
try:
148-
print(node.getCurrentNodeJSVersion())
152+
print("node.js version: " + str(node.getCurrentNodeJSVersion()))
149153
except Exception as err:
150154
print(err)
151155
response = sublime.yes_no_cancel_dialog("Error during installation: \"node.js\" seems not installed on your system. Node.js and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please then change the path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")
@@ -157,7 +161,7 @@ def start():
157161

158162
npm = NPM(check_local=True)
159163
try:
160-
print(npm.getCurrentNPMVersion())
164+
print("npm version: " + str(npm.getCurrentNPMVersion()))
161165
except Exception as err:
162166
print(err)
163167
response = sublime.yes_no_cancel_dialog("Error during installation: \"npm\" seems not installed on your system. Node.js and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please change their custom path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")

0 commit comments

Comments
 (0)