working on #41, fix #42, updated flow-bin to 0.69.0, improved unused variable feature #24, added patreon donate link

Author: pichillilorenzo

CONTRIBUTING.md

@@ -8,7 +8,7 @@ We welcome any type of contribution, not only code. You can help with
 - **QA**: file bug reports, the more details you can give the better (e.g. screenshots with the console open)
 - **Marketing**: writing blog posts, howto's, videos, ...
 - **Code**: take a look at the [open issues](https://github.com/pichillilorenzo/JavaScriptEnhancements/issues). Even if you can't write code, commenting on them, showing that you care about a given issue matters. It helps us triage them.
-- **Money**: we welcome financial contributions in full transparency on [Open Collective](https://opencollective.com/javascriptenhancements) or using [PayPal](https://www.paypal.me/LorenzoPichilli).
+- **Money**: we welcome financial contributions in full transparency on [Open Collective](https://opencollective.com/javascriptenhancements), [Patreon](https://www.patreon.com/bePatron?u=9269604) or using [PayPal](https://www.paypal.me/LorenzoPichilli).
 
 ## Your First Contribution
 
@@ -36,9 +36,10 @@ For feature requests/enhancement, create an issue or use [![Gitter](https://img.
 
 ## Financial contributions
 
-If this project help you reduce time to develop and also you like it, please support it with a donation on [Open Collective](https://opencollective.com/javascriptenhancements) or using [PayPal](https://www.paypal.me/LorenzoPichilli) 😄👍. Thanks!
+If this project helps you reduce time to develop and also you like it, please support it with a donation on [Patreon](https://www.patreon.com/bePatron?u=9269604), [Open Collective](https://opencollective.com/javascriptenhancements) or using [PayPal](https://www.paypal.me/LorenzoPichilli) 😄👍. Thanks!
 
 [![paypal](https://www.paypalobjects.com/en_US/i/btn/btn_donateCC_LG.gif)](https://www.paypal.me/LorenzoPichilli)
+[![Become a Patron](https://img.shields.io/badge/-Becoma%20a%20Patron!-red.svg?style=for-the-badge)](https://www.patreon.com/bePatron?u=9269604)
 <a href="https://opencollective.com/javascriptenhancements/donate" target="_blank">
   <img alt="opencollective" src="https://opencollective.com/javascriptenhancements/donate/[email protected]?color=blue" width=300 />
 </a>

README.md

@@ -8,6 +8,7 @@
 [![license](https://img.shields.io/github/license/mashape/apistatus.svg)](/LICENSE.txt)
 
 [![Donate to this project using Paypal](https://img.shields.io/badge/paypal-donate-yellow.svg)](https://www.paypal.me/LorenzoPichilli)
+[![Donate to this project using Patreon](https://img.shields.io/badge/patreon-donate-yellow.svg)](https://www.patreon.com/bePatron?u=9269604)
 [![Donate to this project using Open Collective](https://img.shields.io/badge/open%20collective-donate-yellow.svg)](https://opencollective.com/javascriptenhancements/donate) [![Backers on Open Collective](https://opencollective.com/javascriptenhancements/backers/badge.svg)](#backers) [![Sponsors on Open Collective](https://opencollective.com/javascriptenhancements/sponsors/badge.svg)](#sponsors)
 
 **JavaScript Enhancements** is a plugin for **Sublime Text 3**.
@@ -51,7 +52,7 @@ If you want use this plugin, you may want **uninstall/disable** the **JavaScript
 In order to work properly, this plugin has some dependencies:
 
 - **Sublime Text 3** (build **3124** or newer)
-- **Node.js** (6 or upper) and **npm** ([nodejs.org](https://nodejs.org) or [nvm](https://github.com/creationix/nvm))
+- **Node.js** (6 or newer) and **npm** ([nodejs.org](https://nodejs.org) or [nvm](https://github.com/creationix/nvm))
 - **TerminalView** (only for _Linux_ and _Mac OS X_) sublime text plugin ([TerminalView](https://github.com/Wramberg/TerminalView)) 
 
 **Not required**, but **useful** for typescript files (Flow wont work on this type of files):
@@ -137,9 +138,10 @@ For feature requests/enhancement, create an issue or use [![Gitter](https://img.
 
 ### Financial contributions
 
-If this project help you reduce time to develop and also you like it, please support it with a donation on [Open Collective](https://opencollective.com/javascriptenhancements) or using [PayPal](https://www.paypal.me/LorenzoPichilli) 😄👍. Thanks!
+If this project helps you reduce time to develop and also you like it, please support it with a donation on [Patreon](https://www.patreon.com/bePatron?u=9269604), [Open Collective](https://opencollective.com/javascriptenhancements/donate) or using [PayPal](https://www.paypal.me/LorenzoPichilli) 😄👍. Thanks!
 
 [![paypal](https://www.paypalobjects.com/en_US/i/btn/btn_donateCC_LG.gif)](https://www.paypal.me/LorenzoPichilli)
+[![Become a Patron](https://img.shields.io/badge/-Becoma%20a%20Patron!-red.svg?style=for-the-badge)](https://www.patreon.com/bePatron?u=9269604)
 <a href="https://opencollective.com/javascriptenhancements/donate" target="_blank">
   <img alt="opencollective" src="https://opencollective.com/javascriptenhancements/donate/[email protected]?color=blue" width=300 />
 </a>

changelog/0.16.12.txt

@@ -0,0 +1,142 @@
+v0.16.12
+
+## Fixes
+
+- Trying to fix #41
+- Fixed "Plugin not honouring ST3 user settings - show_definitions" #42
+
+## Improvements
+
+- Updated flow-bin to 0.69.0
+- Improved unused variable feature
+
+
+v0.16.11
+
+## Fixes
+
+- Trying to fix #41
+
+## Improvements
+
+- Updated flow-bin to 0.68.0
+
+
+v0.16.1
+
+## Fixes
+
+- Fixed NameError: global name 'subprocess' is not defined on /src/libs/terminal.py - Windows OS
+- Fixed NoneType error on self.completions.append(completion) in /src/listeners/completion.py
+
+
+v0.16.0
+
+## Fixes
+
+- Fixed jsdoc generate command
+- Fixed error on refactor safe commands when the file name is empty
+- Fixed export refactor feature preview
+- Fixed some popup colors with different theme color scheme
+- Fixed completions and hover_description that starts with "$"
+- Fixed issue #36, keymap of next flow error feature changed from "super+alt+c" to "super+alt+b"
+
+## Improvements
+
+- Complete code plugin refactoring
+- Improved completions performance using 'flow ide' command
+- Added "code screenshot" feature using [carbon](https://carbon.now.sh/)
+- updated flow-bin to 0.67.1
+- Added initial support for Vue.js (see https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Example-Vue.js-project)
+- Improved extract method feature
+- Improved completions detection from default_autocomplete.json
+- Added Flow warnings
+- Improved unused variable feature
+
+## Misc
+- Changed gutter color (using other available sublime scopes) for errors and unused variable features.
+
+=================================================================
+** THIS PLUGIN IS IN BETA! Thanks for your support in advance! **
+=================================================================
+
+If you like it, remember to star it ⭐ on GitHub: https://github.com/pichillilorenzo/JavaScriptEnhancements
+
+** USAGE **
+===========
+
+See how it works on the Wiki: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki 👈👈
+
+
+** WHAT IS THIS? **
+===================
+
+This plugin uses Flow (javascript static type checker from Facebook) under the hood.
+
+It offers better javascript autocomplete and a lot of features about creating, 
+developing and managing javascript projects, such as:
+
+- Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
+- Ionic v1 and v2 (it includes also v3) projects (same as Cordova projects!)
+- Angular v1 and v2 (it includes also v4 and v5) projects
+- Vue projects (only about the creation at this moment, see https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Example-Vue.js-project)
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also NativeScript support)
+- Express projects (only about the creation at this moment)
+- Yeoman generators
+- Local bookmarks project
+- JavaScript real-time errors
+- Code Refactoring
+- etc.
+
+You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project)!
+
+It turns Sublime Text into a JavaScript IDE like!
+
+This project is based on my other Sublime Text plugin JavaScript Completions (https://github.com/pichillilorenzo/JavaScript-Completions)
+
+** NOTE **
+If you want use this plugin, you may want uninstall/disable the JavaScript Completions plugin, if installed.
+
+** OS SUPPORTED **
+==================
+
+👉 Linux (64-bit)
+👉 Mac OS X 
+👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞. Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
+
+❗❗ Dependencies ❗❗
+=======================
+
+In order to work properly, this plugin has some dependencies:
+
+👉 Sublime Text 3 (build 3124 or newer)
+👉 Node.js and npm (https://nodejs.org or nvm (https://github.com/creationix/nvm))
+👉 TerminalView (only for Linux and Mac OS X) sublime text plugin (https://github.com/Wramberg/TerminalView)
+
+Not required, but useful for typescript files (Flow wont work on this type of files):
+
+👉 TypeScript sublime text plugin (https://github.com/Microsoft/TypeScript-Sublime-Plugin) 
+
+** Flow Requirements **
+=======================
+
+It use [Flow](https://github.com/facebook/flow) for type checking and auto-completions.
+
+👉 Mac OS X
+👉 Linux (64-bit)
+👉 Windows (64-bit)
+
+Email me for any questions or doubts about this new project on: [email protected]
+
+** Donation **
+==============
+
+If this project help you reduce time to develop and also you like it, please support it with a donation 😄👍. Thanks!
+
+Open Collective: https://opencollective.com/javascriptenhancements/donate
+PayPal: https://www.paypal.me/LorenzoPichilli
+
+Thanks anyway for your support! 😄😄
+
+MIT License

main.py

@@ -43,7 +43,15 @@ def start():
     print("node.js version: " + str(node.getCurrentNodeJSVersion()))
   except Exception as err: 
     print(err)
-    response = sublime.yes_no_cancel_dialog("Error during installation: \"node.js\" seems not installed on your system. Node.js and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please then change the path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text. If you don't know the path of it, use \"which node\" (for Linux-based OS) or \"where node.exe\" (for Windows OS) to get it.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")
+    response = sublime.yes_no_cancel_dialog("Error during installation: \"node.js\" seems not installed on your system. Node.js (6 or upper) and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please then change the path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text. If you don't know the path of it, use \"which node\" (for Linux-based OS) or \"where node.exe\" (for Windows OS) to get it.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")
+    if response == sublime.DIALOG_YES:
+      sublime.active_window().run_command("open_url", args={"url": "https://nodejs.org"})
+    elif response == sublime.DIALOG_NO:
+      sublime.active_window().run_command("open_url", args={"url": "https://github.com/creationix/nvm"})
+    return
+
+  if int(str(node.getCurrentNodeJSVersion()).strip().replace('v', '').split('.')[0]) < 6:
+    response = sublime.yes_no_cancel_dialog("JavaScript Enhancement Error\n\nNode.js version required: 6 or newer.\nYour version is: " + str(node.getCurrentNodeJSVersion()) + "\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")
     if response == sublime.DIALOG_YES:
       sublime.active_window().run_command("open_url", args={"url": "https://nodejs.org"})
     elif response == sublime.DIALOG_NO:
@@ -55,7 +63,7 @@ def start():
     print("npm version: " + str(npm.getCurrentNPMVersion()))
   except Exception as err: 
     print(err)
-    response = sublime.yes_no_cancel_dialog("Error during installation: \"npm\" seems not installed on your system. Node.js and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please change their custom path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text. If you don't know the path of it, use \"which npm\" (for Linux-based OS) or \"where npm\" (for Windows OS) to get it.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")
+    response = sublime.yes_no_cancel_dialog("Error during installation: \"npm\" seems not installed on your system. Node.js (6 or upper) and npm are required to be able to use JavaScript Enhancements plugin.\n\nIf you are using \"nvm\" or you have a different path for node.js and npm, please change their custom path on:\n\nPreferences > Package Settings > JavaScript Enhancements > Settings\n\nand restart Sublime Text. If you don't know the path of it, use \"which npm\" (for Linux-based OS) or \"where npm\" (for Windows OS) to get it.\n\nIf this doesn't work then try also to add the path of their binaries in the PATH key-value on the same JavaScript Enhancements settings file. This variable will be used to add them in the $PATH environment variable, so put the symbol \":\" (instead \";\" for Windows) in front of your path.\n\nDo you want open the website of node.js?", "Yes, open it", "Or use nvm")
     if response == sublime.DIALOG_YES:
       sublime.active_window().run_command("open_url", args={"url": "https://nodejs.org"})
     elif response == sublime.DIALOG_NO:
@@ -84,7 +92,7 @@ def start():
       print(result)
       if os.path.exists(node_modules_path):
         shutil.rmtree(node_modules_path)
-      sublime.error_message("Error during installation: can't install npm dependencies for JavaScript Enhancements plugin.\n\nThe error COULD be caused by the npm permission access (EACCES error), so in this case you need to repair/install node.js and npm in a way that doesn't require \"sudo\" command.\n\nFor example you could use a Node Version Manager, such as \"nvm\" or \"nodenv\".\n\nTry to run \"npm install\" inside the package of this plugin to see what you get.\n\nRemember to open an issue on GitHub!")
+      sublime.error_message("Error during installation: can't install npm dependencies for JavaScript Enhancements plugin.\n\nThe error COULD be caused by the npm permission access (EACCES error), so in this case you need to repair/install node.js (6 or upper) and npm in a way that doesn't require \"sudo\" command.\n\nFor example you could use a Node Version Manager, such as \"nvm\" or \"nodenv\".\n\nTry to run \"npm install\" inside the package of this plugin to see what you get.\n\nRemember to open an issue on GitHub!")
       return
 
   Hook.apply('plugin_ready')

messages.json

@@ -21,5 +21,6 @@
   "0.15.0": "changelog/0.15.0.txt",
   "0.16.0": "changelog/0.16.0.txt",
   "0.16.1": "changelog/0.16.1.txt",
-  "0.16.11": "changelog/0.16.11.txt"
+  "0.16.11": "changelog/0.16.11.txt",
+  "0.16.12": "changelog/0.16.12.txt"
 }

package.json

@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "flow-bin": "0.68.0",
+    "flow-bin": "0.69.0",
     "flow-remove-types": "1.2.3",
     "flow-typed": "2.2.3",
     "jsdoc": "3.5.5"

src/commands/can_i_use/can_i_use_data.json

@@ -3,6 +3,7 @@
 from ..hook import Hook
 from .flow_cli import FlowCLI
 from .main import get_flow_path
+from ..node import NodeJS
 
 flow_ide_clients = {}
 
@@ -24,13 +25,18 @@ def start_stdio_server(self, on_receive, on_closed, options = []):
       return
 
     flow_path = get_flow_path()
-  
+    node_path = []
+
+    if sublime.platform() != 'windows':
+      node = NodeJS()
+      node_path = [node.node_js_path]
+
     si = None
     if os.name == "nt":
         si = subprocess.STARTUPINFO()  # type: ignore
         si.dwFlags |= subprocess.SW_HIDE | subprocess.STARTF_USESHOWWINDOW  # type: ignore
 
-    args = flow_path + ["ide", "--protocol", "very-unstable", "--from", "sublime_text"] + options + ["--root", self.root]
+    args = node_path + flow_path + ["ide", "--protocol", "very-unstable", "--from", "sublime_text"] + options + ["--root", self.root]
     print("starting flow ide server: " + str(args))
     sublime.status_message('Starting flow ide server, root: ' + self.root)
 

src/libs/flow/flow_ide_server.py

@@ -1,6 +1,6 @@
 import os
 
-PLUGIN_VERSION = "0.16.11"
+PLUGIN_VERSION = "0.16.12"
 DEVELOPER_MODE = False
 
 PACKAGE_PATH = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))

src/libs/global_vars.py

@@ -60,7 +60,7 @@ def on_hover(self, view, point, hover_zone) :
     if not view.match_selector(
         point,
         'source.js - string - constant - comment'
-    ):
+    ) or not view.settings().get("show_definitions"):
       return
 
     if hover_zone != sublime.HOVER_TEXT :