fix not closing wit no selection in popup after adding new project type

Author: pichillilorenzo

README.md

@@ -21,6 +21,8 @@ developing and managing **javascript projects**, such as:
 - JavaScript real-time errors
 - etc.
 
+You could use it also in **existing projects** (see the [Wiki](https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki))!
+
 It will turn Sublime Text into a **JavaScript IDE** like!
 
 This project is based on my other Sublime Text plugin [JavaScript Completions](https://github.com/pichillilorenzo/JavaScript-Completions)
@@ -37,7 +39,7 @@ If you want use this plugin, you may want **uninstall/disable** the **JavaScript
 
 In order to work properly, this plugin has some dependencies:
 
-- Sublime Text 3 (build 3124 or newer)
+- **Sublime Text 3** (build **3124** or newer)
 - **Node.js** and **npm** ([nodejs.org](https://nodejs.org) or [nvm](https://github.com/creationix/nvm))
 - **TerminalView** sublime text plugin ([TerminalView](https://github.com/Wramberg/TerminalView)) 
 

_generated_2018_01_01_at_16_07_42.py renamed to _generated_2018_01_01_at_16_42_01.py

@@ -1650,7 +1650,7 @@ def project_path_on_done(self, path):
     path = shlex.quote( path.strip() )
 
     if os.path.isdir(os.path.join(path, PROJECT_SETTINGS_FOLDER_NAME)):
-      sublime.error_message(path+" is not empty. Can not create the project.")
+      sublime.error_message("Can't create the project. There is already another project in "+path+".")
       return
 
     if not os.path.isdir(path):
@@ -1687,17 +1687,18 @@ def project_path_on_done(self, path):
     with open(project_settings, 'w+', encoding="utf-8") as file:
       file.write(json.dumps(default_config["project_settings"], indent=2))
 
-    # node = NodeJS()
-    # result = node.execute("flow", ["init"], is_from_bin=True, chdir=path)
-    # if not result[0]:
-    #   sublime.error_message("Can not init flow.")
-    # else:
-    #   with open(flowconfig_file_path, 'r+', encoding="utf-8") as file:
-    #     content = file.read()
-    #     content = content.replace("[ignore]", """[ignore]""")
-    #     file.seek(0)
-    #     file.truncate()
-    #     file.write(content)
+    if not os.path.exists(flowconfig_file_path) :
+      node = NodeJS(check_local=True)
+      result = node.execute("flow", ["init"], is_from_bin=True, chdir=path)
+      if not result[0]:
+        sublime.error_message("Can't initialize flow.")
+      # else:
+      #   with open(flowconfig_file_path, 'r+', encoding="utf-8") as file:
+      #     content = file.read()
+      #     content = content.replace("[ignore]", """[ignore]""")
+      #     file.seek(0)
+      #     file.truncate()
+      #     file.write(content)
 
     Hook.apply(self.project_type+"_after_create_new_project", path, "create_new_project")
     Hook.apply("after_create_new_project", path, "create_new_project")
@@ -1718,6 +1719,9 @@ def run(self, **kwargs):
 
   def project_type_selected(self, index):
 
+    if index == -1:
+      return
+
     self.project_type = PROJECT_TYPE_SUPPORTED[index]
     self.window.show_input_panel("Working Directory:", self.settings["project_dir_name"]+os.path.sep, self.working_directory_on_done, None, None)
 
@@ -1750,6 +1754,9 @@ def run(self, *args):
 
   def project_type_selected(self, index):
 
+    if index == -1:
+      return
+
     self.project_type = PROJECT_TYPE_SUPPORTED[index]
     self.window.show_input_panel("Working directory:", self.settings["project_dir_name"]+os.path.sep, self.working_directory_on_done, None, None)
 
@@ -3914,7 +3921,7 @@ def on_modified_async_with_thread(self, recheck=True) :
 
   def on_hover(self, point, hover_zone) :
     view = self.view
-    #view.erase_phantoms("flow_error")
+
     if hover_zone != sublime.HOVER_TEXT :
       return
 
@@ -3995,8 +4002,6 @@ def on_selection_modified_async(self, *args) :
     ) and not view.find_by_selector("source.js.embedded.html")) or not self.errors or not view.get_regions("flow_error"):
       hide_flow_errors(view)
       return
- 
-    view.erase_phantoms("flow_error")
 
     settings = get_project_settings()
     if settings :
@@ -4834,6 +4839,10 @@ def start():
 
   global mainPlugin
 
+  if sublime.platform() == 'windows':
+    sublime.error_message("Windows is not supported by this plugin for now.")
+    return
+
   try:
     sys.modules["TerminalView"]
   except Exception as err:

helper/javascript_completions/show_flow_errors_view_event_listener.py

@@ -112,7 +112,7 @@ def on_modified_async_with_thread(self, recheck=True) :
 
   def on_hover(self, point, hover_zone) :
     view = self.view
-    #view.erase_phantoms("flow_error")
+
     if hover_zone != sublime.HOVER_TEXT :
       return
 
@@ -193,8 +193,6 @@ def on_selection_modified_async(self, *args) :
     ) and not view.find_by_selector("source.js.embedded.html")) or not self.errors or not view.get_regions("flow_error"):
       hide_flow_errors(view)
       return
- 
-    view.erase_phantoms("flow_error")
 
     settings = get_project_settings()
     if settings :

make/_init.py

@@ -103,6 +103,10 @@ def start():
 
   global mainPlugin
 
+  if sublime.platform() == 'windows':
+    sublime.error_message("Windows is not supported by this plugin for now.")
+    return
+
   try:
     sys.modules["TerminalView"]
   except Exception as err:

project/create_new_project/create_new_project.py

@@ -21,7 +21,7 @@ def project_path_on_done(self, path):
     path = shlex.quote( path.strip() )
 
     if os.path.isdir(os.path.join(path, PROJECT_SETTINGS_FOLDER_NAME)):
-      sublime.error_message(path+" is not empty. Can not create the project.")
+      sublime.error_message("Can't create the project. There is already another project in "+path+".")
       return
 
     if not os.path.isdir(path):
@@ -58,17 +58,18 @@ def project_path_on_done(self, path):
     with open(project_settings, 'w+', encoding="utf-8") as file:
       file.write(json.dumps(default_config["project_settings"], indent=2))
 
-    # node = NodeJS()
-    # result = node.execute("flow", ["init"], is_from_bin=True, chdir=path)
-    # if not result[0]:
-    #   sublime.error_message("Can not init flow.")
-    # else:
-    #   with open(flowconfig_file_path, 'r+', encoding="utf-8") as file:
-    #     content = file.read()
-    #     content = content.replace("[ignore]", """[ignore]""")
-    #     file.seek(0)
-    #     file.truncate()
-    #     file.write(content)
+    if not os.path.exists(flowconfig_file_path) :
+      node = NodeJS(check_local=True)
+      result = node.execute("flow", ["init"], is_from_bin=True, chdir=path)
+      if not result[0]:
+        sublime.error_message("Can't initialize flow.")
+      # else:
+      #   with open(flowconfig_file_path, 'r+', encoding="utf-8") as file:
+      #     content = file.read()
+      #     content = content.replace("[ignore]", """[ignore]""")
+      #     file.seek(0)
+      #     file.truncate()
+      #     file.write(content)
 
     Hook.apply(self.project_type+"_after_create_new_project", path, "create_new_project")
     Hook.apply("after_create_new_project", path, "create_new_project")
@@ -89,6 +90,9 @@ def run(self, **kwargs):
 
   def project_type_selected(self, index):
 
+    if index == -1:
+      return
+
     self.project_type = PROJECT_TYPE_SUPPORTED[index]
     self.window.show_input_panel("Working Directory:", self.settings["project_dir_name"]+os.path.sep, self.working_directory_on_done, None, None)
 
@@ -121,6 +125,9 @@ def run(self, *args):
 
   def project_type_selected(self, index):
 
+    if index == -1:
+      return
+
     self.project_type = PROJECT_TYPE_SUPPORTED[index]
     self.window.show_input_panel("Working directory:", self.settings["project_dir_name"]+os.path.sep, self.working_directory_on_done, None, None)