fix #8, fix #18, fix #17, fix on_hover_description tooltip on a quoted strings or numeric constants

Author: pichillilorenzo

README.md

@@ -16,9 +16,9 @@ It offers better **javascript autocomplete** and also a lot of features about cr
 - Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
 - Ionic v1 and v2 projects (same as Cordova projects!)
 - Angular v1 and v2 projects
-- React projects (only about the creation at this time)
-- React Native projects (only about the creation at this time. I will add also **NativeScript** support)
-- Express projects (only about the creation at this time)
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also **NativeScript** support)
+- Express projects (only about the creation at this moment)
 - Yeoman generators
 - Local bookmarks project
 - JavaScript real-time errors
@@ -63,7 +63,7 @@ You can find more information about Flow on [flow.org](https://flow.org)
 
 ## Installation
 
-With [Package Control](https://packagecontrol.io/) (**NOT PUBLISHED YET**):
+With [Package Control](https://packagecontrol.io/):
 
 - Run “Package Control: Install Package” command or click to the `Preferences > Package Control` menu item, find and install `JavaScript Enhancements` plugin.
 

_generated_2018_01_17_at_02_32_47.py renamed to _generated_2018_01_22_at_20_19_53.py

@@ -3,7 +3,7 @@
 from shutil import copyfile
 from threading import Timer
 
-PLUGIN_VERSION = "0.13.11"
+PLUGIN_VERSION = "0.13.12"
 
 PACKAGE_PATH = os.path.abspath(os.path.dirname(__file__))
 PACKAGE_NAME = os.path.basename(PACKAGE_PATH)
@@ -723,20 +723,20 @@ def trim_Region(view, region):
 
   @staticmethod
   def selection_in_js_scope(view, point = -1, except_for = ""):
-    selections = view.sel()
+    try :
 
-    if not selections:
-      return False
+      sel_begin = view.sel()[0].begin() if point == -1 else point
 
-    sel_begin = selections[0].begin() if point == -1 else point
+      return view.match_selector(
+        sel_begin,
+        'source.js ' + except_for
+      ) or view.match_selector(
+        sel_begin,
+        'source.js.embedded.html ' + except_for
+      )
 
-    return view.match_selector(
-      sel_begin,
-      'source.js ' + except_for
-    ) or view.match_selector(
-      sel_begin,
-      'source.js.embedded.html ' + except_for
-    )
+    except IndexError as e:
+      return False   
 
   @staticmethod
   def replace_with_tab(view, region, pre="", after="", add_to_each_line_before="", add_to_each_line_after="") :
@@ -1660,7 +1660,7 @@ def run(self, **kwargs):
       if not self.command:
         self.command = kwargs.get("command")
       else:
-        self.command += kwargs.get("command")
+        self.command += [kwargs.get("command")]
 
       self.prepare_command(**kwargs)
 
@@ -1689,7 +1689,7 @@ def run(self, **kwargs):
       if not self.command:
         self.command = kwargs.get("command")
       else:
-        self.command += kwargs.get("command")
+        self.command += [kwargs.get("command")]
 
       self.prepare_command(**kwargs)
 
@@ -4094,7 +4094,7 @@ class on_hover_descriptionEventListener(sublime_plugin.EventListener):
   def on_hover(self, view, point, hover_zone) :
     if not view.match_selector(
         point,
-        'source.js - comment'
+        'source.js - string - constant - comment'
     ):
       return
 
@@ -4255,6 +4255,7 @@ def on_hover_description_async(view, point, hover_zone, popup_position, show_hin
 
     if result[0] and result[1].get("type") and result[1]["type"] != "(unknown)":
 
+      print(result[1])
       results_found = 1
 
       description = dict()
@@ -5584,7 +5585,7 @@ def on_modified_async_with_thread(self, recheck=True):
 
             repetitions[variableName] = [variableRegion]
 
-          items = Util.nested_lookup("type", ["MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression"], body)
+          items = Util.nested_lookup("type", ["VariableDeclarator", "MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression"], body)
           for item in items:
 
             if "object" in item :
@@ -5635,6 +5636,9 @@ def on_modified_async_with_thread(self, recheck=True):
             elif "value" in item and isinstance(item["value"],dict) and "name" in item["value"] and item["value"]["type"] == "Identifier":
               item = item["value"]
 
+            elif "init" in item and isinstance(item["init"],dict) and "name" in item["init"] and item["init"]["type"] == "Identifier":
+              item = item["init"]
+
             elif "body" in item and isinstance(item["body"],dict) and "name" in item["body"] and item["body"]["type"] == "Identifier":
               item = item["body"]
 

changelog/0.13.12.txt

@@ -0,0 +1,88 @@
+v0.13.12
+
+## Fixes
+
+- Fixed "Unused variables - variable remains underlined also when it is used in an assignment statement" #18
+- Fixed "Evaluate JavaScript - TypeError: 'NoneType' object is not iterable on self.command += kwargs.get("command")" #17
+- Not showing the on_hover_description tooltip on a quoted strings or numeric constants, in order to prevent "Go to definition" on them
+
+## Improvements
+
+- Finally published on Package Control ⭐
+
+
+
+=================================================================
+** THIS PLUGIN IS IN BETA! Thanks for your support in advance! **
+=================================================================
+
+If you like it, remember to star it ⭐ on GitHub: https://github.com/pichillilorenzo/JavaScriptEnhancements
+
+** USAGE **
+===========
+
+See how it works on the Wiki: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki 👈👈
+
+
+** WHAT IS THIS? **
+===================
+
+This plugin uses Flow (javascript static type checker from Facebook) under the hood.
+
+It offers better javascript autocomplete and a lot of features about creating, 
+developing and managing javascript projects, such as:
+
+- Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
+- Ionic v1 and v2 projects (same as Cordova projects!)
+- Angular v1 and v2 projects
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also NativeScript support)
+- Express projects (only about the creation at this moment)
+- Yeoman generators
+- Local bookmarks project
+- JavaScript real-time errors
+- etc.
+
+You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project)!
+
+It turns Sublime Text into a JavaScript IDE like!
+
+This project is based on my other Sublime Text plugin JavaScript Completions (https://github.com/pichillilorenzo/JavaScript-Completions)
+
+** NOTE **
+If you want use this plugin, you may want uninstall/disable the JavaScript Completions plugin, if installed.
+
+** OS SUPPORTED NOW **
+======================
+
+👉 Linux (64-bit)
+👉 Mac OS X 
+👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞. Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
+
+❗❗ Dependencies ❗❗
+=======================
+
+In order to work properly, this plugin has some dependencies:
+
+👉 Sublime Text 3 (build 3124 or newer)
+👉 Node.js and npm (https://nodejs.org or nvm (https://github.com/creationix/nvm))
+👉 TerminalView (only for Linux and Mac OS X) sublime text plugin (https://github.com/Wramberg/TerminalView)
+
+Not required, but useful for typescript files (Flow wont work on this type of files):
+
+👉 TypeScript sublime text plugin (https://github.com/Microsoft/TypeScript-Sublime-Plugin) 
+
+** Flow Requirements **
+=======================
+
+It use [Flow](https://github.com/facebook/flow) for type checking and auto-completions.
+
+👉 Mac OS X
+👉 Linux (64-bit)
+👉 Windows (64-bit)
+
+Email me for any questions or doubts about this new project on: [email protected]
+
+Thanks for your support! 😄😄
+
+MIT License

changelog/install.txt

@@ -21,15 +21,15 @@ developing and managing javascript projects, such as:
 - Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
 - Ionic v1 and v2 projects (same as Cordova projects!)
 - Angular v1 and v2 projects
-- React projects
-- React Native projects (only about the creation for the moment. I will add also NativeScript support)
-- Express projects (only about the creation for the moment)
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also NativeScript support)
+- Express projects (only about the creation at this moment)
 - Yeoman generators
 - Local bookmarks project
 - JavaScript real-time errors
 - etc.
 
-You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki)!
+You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project)!
 
 It turns Sublime Text into a JavaScript IDE like!
 

helper/can_i_use/can_i_use_data.json

@@ -42,7 +42,7 @@ class on_hover_descriptionEventListener(sublime_plugin.EventListener):
   def on_hover(self, view, point, hover_zone) :
     if not view.match_selector(
         point,
-        'source.js - comment'
+        'source.js - string - constant - comment'
     ):
       return
 
@@ -203,6 +203,7 @@ def on_hover_description_async(view, point, hover_zone, popup_position, show_hin
 
     if result[0] and result[1].get("type") and result[1]["type"] != "(unknown)":
 
+      print(result[1])
       results_found = 1
 
       description = dict()

helper/javascript_completions/on_hover_description_event_listener.py

@@ -141,7 +141,7 @@ def on_modified_async_with_thread(self, recheck=True):
 
             repetitions[variableName] = [variableRegion]
 
-          items = Util.nested_lookup("type", ["MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression"], body)
+          items = Util.nested_lookup("type", ["VariableDeclarator", "MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression"], body)
           for item in items:
 
             if "object" in item :
@@ -192,6 +192,9 @@ def on_modified_async_with_thread(self, recheck=True):
             elif "value" in item and isinstance(item["value"],dict) and "name" in item["value"] and item["value"]["type"] == "Identifier":
               item = item["value"]
 
+            elif "init" in item and isinstance(item["init"],dict) and "name" in item["init"] and item["init"]["type"] == "Identifier":
+              item = item["init"]
+
             elif "body" in item and isinstance(item["body"],dict) and "name" in item["body"] and item["body"]["type"] == "Identifier":
               item = item["body"]
 

helper/unused_variables_view_event_listener.py

@@ -295,20 +295,20 @@ def trim_Region(view, region):
 
   @staticmethod
   def selection_in_js_scope(view, point = -1, except_for = ""):
-    selections = view.sel()
+    try :
 
-    if not selections:
-      return False
+      sel_begin = view.sel()[0].begin() if point == -1 else point
 
-    sel_begin = selections[0].begin() if point == -1 else point
+      return view.match_selector(
+        sel_begin,
+        'source.js ' + except_for
+      ) or view.match_selector(
+        sel_begin,
+        'source.js.embedded.html ' + except_for
+      )
 
-    return view.match_selector(
-      sel_begin,
-      'source.js ' + except_for
-    ) or view.match_selector(
-      sel_begin,
-      'source.js.embedded.html ' + except_for
-    )
+    except IndexError as e:
+      return False   
 
   @staticmethod
   def replace_with_tab(view, region, pre="", after="", add_to_each_line_before="", add_to_each_line_after="") :

helper/util/main.py

@@ -3,7 +3,7 @@
 from shutil import copyfile
 from threading import Timer
 
-PLUGIN_VERSION = "0.13.11"
+PLUGIN_VERSION = "0.13.12"
 
 PACKAGE_PATH = os.path.abspath(os.path.dirname(__file__))
 PACKAGE_NAME = os.path.basename(PACKAGE_PATH)

make/_init.py

@@ -11,5 +11,6 @@
   "0.11.11": "changelog/0.11.11.txt",
   "0.13.0": "changelog/0.13.0.txt",
   "0.13.1": "changelog/0.13.1.txt",
-  "0.13.11": "changelog/0.13.11.txt"
+  "0.13.11": "changelog/0.13.11.txt",
+  "0.13.12": "changelog/0.13.12.txt"
 }