windows: Fixed onLoadResourceWithCustomScheme WebView event called every time

Author: pichillilorenzo

flutter_inappwebview_windows/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.5.0+1
+
+- Fixed `onLoadResourceWithCustomScheme` WebView event called every time
+
 ## 0.5.0
 
 - Implemented `shouldInterceptRequest`, `onLoadResourceWithCustomScheme` WebView events

flutter_inappwebview_windows/pubspec.yaml

@@ -1,6 +1,6 @@
 name: flutter_inappwebview_windows
 description: Windows implementation of the flutter_inappwebview plugin.
-version: 0.5.0
+version: 0.5.0+1
 homepage: https://inappwebview.dev/
 repository: https://github.com/pichillilorenzo/flutter_inappwebview/tree/master/flutter_inappwebview_windows
 issue_tracker: https://github.com/pichillilorenzo/flutter_inappwebview/issues

flutter_inappwebview_windows/windows/in_app_webview/in_app_webview.cpp

@@ -835,6 +835,12 @@ namespace flutter_inappwebview_plugin
           if (channelDelegate && succeededOrLog(args->get_Request(&webResourceRequest)) && succeededOrLog(args->GetDeferral(&deferral))) {
             auto request = std::make_shared<WebResourceRequest>(webResourceRequest);
 
+            // The add_WebResourceRequested event is by default raised for file, http, and https URI schemes.
+            // This is also raised for registered custom URI schemes.
+            // https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2?view=webview2-1.0.2792.45#add_webresourcerequested
+            auto url = request->url.has_value() ? request->url.value() : "";
+            auto isCustomScheme = !url.empty() && !starts_with(url, std::string{ "file://" }) && !starts_with(url, std::string{ "http://" }) && !starts_with(url, std::string{ "https://" });
+
             auto onLoadResourceWithCustomSchemeCallback = [this, deferral, request, args]()
               {
                 if (channelDelegate) {
@@ -874,9 +880,14 @@ namespace flutter_inappwebview_plugin
                   failedLog(deferral->Complete());
                   return false;
                 };
-              callback->nullSuccess = [this, deferral, args, onLoadResourceWithCustomSchemeCallback]()
+              callback->nullSuccess = [this, deferral, args, isCustomScheme, onLoadResourceWithCustomSchemeCallback]()
                 {
-                  onLoadResourceWithCustomSchemeCallback();
+                  if (isCustomScheme) {
+                    onLoadResourceWithCustomSchemeCallback();
+                  }
+                  else {
+                    failedLog(deferral->Complete());
+                  }
                   return false;
                 };
               callback->defaultBehaviour = defaultBehaviour;
@@ -887,9 +898,12 @@ namespace flutter_inappwebview_plugin
                 };
               channelDelegate->shouldInterceptRequest(request, std::move(callback));
             }
-            else {
+            else if (isCustomScheme) {
               onLoadResourceWithCustomSchemeCallback();
             }
+            else {
+              failedLog(deferral->Complete());
+            }
           }
           return S_OK;
         }

flutter_inappwebview_windows/windows/types/custom_scheme_registration.h

@@ -4,7 +4,6 @@
 #include <flutter/standard_method_codec.h>
 #include <optional>
 #include <WebView2EnvironmentOptions.h>
-#include <wil/com.h>
 
 namespace flutter_inappwebview_plugin
 {

flutter_inappwebview_windows/windows/utils/string.h

@@ -176,6 +176,18 @@ namespace flutter_inappwebview_plugin
       [](const T v) { return static_cast<T>(std::toupper(v)); });
     return s2;
   }
+
+  template <typename T>
+  bool starts_with(const std::basic_string<T>& str, const std::basic_string<T>& prefix)
+  {
+    return str.size() >= prefix.size() && str.compare(0, prefix.size(), prefix) == 0;
+  }
+
+  template <typename T>
+  bool ends_with(const std::basic_string<T>& str, const std::basic_string<T>& suffix)
+  {
+    return str.size() >= suffix.size() && str.compare(str.size() - suffix.size(), suffix.size(), suffix) == 0;
+  }
 }
 
 #endif //FLUTTER_INAPPWEBVIEW_PLUGIN_UTIL_STRING_H_