Rewire diff context menu item

Author: tiennou

Classes/Controllers/PBGitHistoryController.m

@@ -648,7 +648,10 @@ - (NSArray *)menuItemsForPaths:(NSArray *)paths
 {
 	if ([sender isKindOfClass:[PBRefMenuItem class]]) {
 		id <PBGitRefish> refish = [[(PBRefMenuItem *)sender refishs] firstObject];
-		return refish;
+
+		if (!types || [types indexOfObject:[refish refishType]] != NSNotFound)
+			return refish;
+		return nil;
 	}
 
 	if ([types indexOfObject:kGitXCommitType] == NSNotFound)
@@ -810,6 +813,19 @@ - (IBAction)showDeleteRefSheet:(PBRefMenuItem *)sender
 				  }];
 }
 
+- (IBAction)diffWithHEAD:(id)sender
+{
+	id <PBGitRefish> refish = [self refishForSender:sender refishTypes:nil];
+	if (!refish)
+		return;
+
+	PBGitCommit *commit = [self.repository commitForRef:refish];
+
+	NSString *diff = [self.repository performDiff:commit against:nil forFiles:nil];
+
+	[PBDiffWindowController showDiff:diff];
+}
+
 #pragma mark -
 #pragma mark Quick Look
 

Classes/Controllers/PBRefController.m

@@ -26,32 +26,6 @@ - (void)awakeFromNib
 	[commitList registerForDraggedTypes:[NSArray arrayWithObject:@"PBGitRef"]];
 }
 
-- (NSArray<PBGitCommit *> *) commitsForMenuItem:(PBRefMenuItem *)menuItem {
-	NSArray<id<PBGitRefish>> * refishs = menuItem.refishs;
-	NSMutableArray *commits = [NSMutableArray arrayWithCapacity:refishs.count];
-	for (id<PBGitRefish> refish in refishs) {
-		[commits addObject:[self refishToCommit:refish]];
-	}
-	return commits;
-}
-
-- (PBGitCommit *) refishToCommit:(id<PBGitRefish>)refish {
-	return [refish refishType] == kGitXCommitType
-		? (PBGitCommit *)refish
-		: [historyController.repository commitForRef:refish];
-}
-
-
-#pragma mark Diff
-
-- (void) diffWithHEAD:(PBRefMenuItem *)sender
-{
-	PBGitCommit *commit = [self commitsForMenuItem:sender].firstObject;
-	NSString *diff = [historyController.repository performDiff:commit against:nil forFiles:nil];
-
-	[PBDiffWindowController showDiff:diff];
-}
-
 #pragma mark Stash
 
 - (IBAction) stashPop:(PBRefMenuItem *)sender