Skip to content

Commit 8748859

Browse files
committed
Merge tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
Pull clk fixes from Stephen Boyd: "A few Allwinner clk driver fixes: - Mark Allwinner A523 MBUS clock as critical to avoid system stalls - Fix names of CSI related clocks on Allwinner V3s. This includes changes to the driver, DT bindings and DT files. - Fix parents of TCON clock on Allwinner V3s" * tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux: clk: sunxi-ng: v3s: Fix TCON clock parents clk: sunxi-ng: v3s: Fix CSI1 MCLK clock name clk: sunxi-ng: v3s: Fix CSI SCLK clock name clk: sunxi-ng: a523: Mark MBUS clock as critical
2 parents 302f88f + e4b2a0c commit 8748859

File tree

7 files changed

+14
-13
lines changed

7 files changed

+14
-13
lines changed

Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ examples:
110110
reg = <0x01cb4000 0x1000>;
111111
interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
112112
clocks = <&ccu CLK_BUS_CSI>,
113-
<&ccu CLK_CSI1_SCLK>,
113+
<&ccu CLK_CSI_SCLK>,
114114
<&ccu CLK_DRAM_CSI>;
115115
clock-names = "bus",
116116
"mod",

Documentation/devicetree/bindings/media/allwinner,sun6i-a31-isp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ examples:
7979
reg = <0x01cb8000 0x1000>;
8080
interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
8181
clocks = <&ccu CLK_BUS_CSI>,
82-
<&ccu CLK_CSI1_SCLK>,
82+
<&ccu CLK_CSI_SCLK>,
8383
<&ccu CLK_DRAM_CSI>;
8484
clock-names = "bus", "mod", "ram";
8585
resets = <&ccu RST_BUS_CSI>;

Documentation/devicetree/bindings/media/allwinner,sun6i-a31-mipi-csi2.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ examples:
103103
reg = <0x01cb1000 0x1000>;
104104
interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
105105
clocks = <&ccu CLK_BUS_CSI>,
106-
<&ccu CLK_CSI1_SCLK>;
106+
<&ccu CLK_CSI_SCLK>;
107107
clock-names = "bus", "mod";
108108
resets = <&ccu RST_BUS_CSI>;
109109

arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@
652652
reg = <0x01cb4000 0x3000>;
653653
interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
654654
clocks = <&ccu CLK_BUS_CSI>,
655-
<&ccu CLK_CSI1_SCLK>,
655+
<&ccu CLK_CSI_SCLK>,
656656
<&ccu CLK_DRAM_CSI>;
657657
clock-names = "bus", "mod", "ram";
658658
resets = <&ccu RST_BUS_CSI>;

drivers/clk/sunxi-ng/ccu-sun55i-a523.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,8 @@ static SUNXI_CCU_MP_DATA_WITH_MUX_GATE_FEAT(mbus_clk, "mbus", mbus_parents,
385385
0, 0, /* no P */
386386
24, 3, /* mux */
387387
BIT(31), /* gate */
388-
0, CCU_FEATURE_UPDATE_BIT);
388+
CLK_IS_CRITICAL,
389+
CCU_FEATURE_UPDATE_BIT);
389390

390391
static const struct clk_hw *mbus_hws[] = { &mbus_clk.common.hw };
391392

drivers/clk/sunxi-ng/ccu-sun8i-v3s.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ static SUNXI_CCU_M_WITH_MUX_GATE(de_clk, "de", de_parents,
350350
0x104, 0, 4, 24, 2, BIT(31),
351351
CLK_SET_RATE_PARENT);
352352

353-
static const char * const tcon_parents[] = { "pll-video" };
353+
static const char * const tcon_parents[] = { "pll-video", "pll-periph0" };
354354
static SUNXI_CCU_M_WITH_MUX_GATE(tcon_clk, "tcon", tcon_parents,
355355
0x118, 0, 4, 24, 3, BIT(31), 0);
356356

@@ -362,11 +362,11 @@ static const char * const csi_mclk_parents[] = { "osc24M", "pll-video",
362362
static SUNXI_CCU_M_WITH_MUX_GATE(csi0_mclk_clk, "csi0-mclk", csi_mclk_parents,
363363
0x130, 0, 5, 8, 3, BIT(15), 0);
364364

365-
static const char * const csi1_sclk_parents[] = { "pll-video", "pll-isp" };
366-
static SUNXI_CCU_M_WITH_MUX_GATE(csi1_sclk_clk, "csi-sclk", csi1_sclk_parents,
365+
static const char * const csi_sclk_parents[] = { "pll-video", "pll-isp" };
366+
static SUNXI_CCU_M_WITH_MUX_GATE(csi_sclk_clk, "csi-sclk", csi_sclk_parents,
367367
0x134, 16, 4, 24, 3, BIT(31), 0);
368368

369-
static SUNXI_CCU_M_WITH_MUX_GATE(csi1_mclk_clk, "csi-mclk", csi_mclk_parents,
369+
static SUNXI_CCU_M_WITH_MUX_GATE(csi1_mclk_clk, "csi1-mclk", csi_mclk_parents,
370370
0x134, 0, 5, 8, 3, BIT(15), 0);
371371

372372
static SUNXI_CCU_M_WITH_GATE(ve_clk, "ve", "pll-ve",
@@ -452,7 +452,7 @@ static struct ccu_common *sun8i_v3s_ccu_clks[] = {
452452
&tcon_clk.common,
453453
&csi_misc_clk.common,
454454
&csi0_mclk_clk.common,
455-
&csi1_sclk_clk.common,
455+
&csi_sclk_clk.common,
456456
&csi1_mclk_clk.common,
457457
&ve_clk.common,
458458
&ac_dig_clk.common,
@@ -551,7 +551,7 @@ static struct clk_hw_onecell_data sun8i_v3s_hw_clks = {
551551
[CLK_TCON0] = &tcon_clk.common.hw,
552552
[CLK_CSI_MISC] = &csi_misc_clk.common.hw,
553553
[CLK_CSI0_MCLK] = &csi0_mclk_clk.common.hw,
554-
[CLK_CSI1_SCLK] = &csi1_sclk_clk.common.hw,
554+
[CLK_CSI_SCLK] = &csi_sclk_clk.common.hw,
555555
[CLK_CSI1_MCLK] = &csi1_mclk_clk.common.hw,
556556
[CLK_VE] = &ve_clk.common.hw,
557557
[CLK_AC_DIG] = &ac_dig_clk.common.hw,
@@ -633,7 +633,7 @@ static struct clk_hw_onecell_data sun8i_v3_hw_clks = {
633633
[CLK_TCON0] = &tcon_clk.common.hw,
634634
[CLK_CSI_MISC] = &csi_misc_clk.common.hw,
635635
[CLK_CSI0_MCLK] = &csi0_mclk_clk.common.hw,
636-
[CLK_CSI1_SCLK] = &csi1_sclk_clk.common.hw,
636+
[CLK_CSI_SCLK] = &csi_sclk_clk.common.hw,
637637
[CLK_CSI1_MCLK] = &csi1_mclk_clk.common.hw,
638638
[CLK_VE] = &ve_clk.common.hw,
639639
[CLK_AC_DIG] = &ac_dig_clk.common.hw,

include/dt-bindings/clock/sun8i-v3s-ccu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
#define CLK_TCON0 64
9797
#define CLK_CSI_MISC 65
9898
#define CLK_CSI0_MCLK 66
99-
#define CLK_CSI1_SCLK 67
99+
#define CLK_CSI_SCLK 67
100100
#define CLK_CSI1_MCLK 68
101101
#define CLK_VE 69
102102
#define CLK_AC_DIG 70

0 commit comments

Comments
 (0)