Skip to content

Commit ab16122

Browse files
JackThomson2willdeacon
authored andcommitted
arm64: kvm, smccc: Fix vendor uuid
Commit 1342306 ("arm64: kvm, smccc: Introduce and use API for getting hypervisor UUID") replaced the explicit register constants with the UUID_INIT macro. However, there is an endian issue, meaning the UUID generated and used in the handshake didn't match UUID prior to the commit. The change in UUID causes the SMCCC vendor handshake to fail with older guest kernels, meaning devices such as PTP were not available in the guest. This patch updates the parameters to the macro to generate a UUID which matches the previous value, and re-establish backwards compatibility with older guest kernels. Fixes: 1342306 ("arm64: kvm, smccc: Introduce and use API for getting hypervisor UUID") Signed-off-by: Jack Thomson <[email protected]> Reviewed-by: Marc Zyngier <[email protected]> Tested-by: Marc Zyngier <[email protected]> Reviewed-by: Sudeep Holla <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 9dd1757 commit ab16122

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/arm-smccc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113

114114
/* KVM UID value: 28b46fb6-2ec5-11e9-a9ca-4b564d003a74 */
115115
#define ARM_SMCCC_VENDOR_HYP_UID_KVM UUID_INIT(\
116-
0xb66fb428, 0xc52e, 0xe911, \
116+
0x28b46fb6, 0x2ec5, 0x11e9, \
117117
0xa9, 0xca, 0x4b, 0x56, \
118118
0x4d, 0x00, 0x3a, 0x74)
119119

0 commit comments

Comments
 (0)